NET-10871 Remove unnecessary resource permissions in connect-inject ClusterRole #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathancoleman
force-pushed
the
connect-inject-clusterrole
branch
from
54ba1fb
to
5912342
Compare
sarahalsmiller
approved these changes
Sep 5, 2024
|
Looks good when CI passes 👍 |
NiniOak
approved these changes
Sep 5, 2024
This was referenced Sep 6, 2024
nathancoleman
added a commit
that referenced
this pull request
Sep 6, 2024
…lusterRole (#4307) * Remove unnecessary resource permissions in connect-inject ClusterRole * Add changelog entry * Update unit test coverage * Update broken unit test * Update broken unit test * Update broken unit test
nathancoleman
added a commit
that referenced
this pull request
Sep 6, 2024
…lusterRole (#4307) * Remove unnecessary resource permissions in connect-inject ClusterRole * Add changelog entry * Update unit test coverage * Update broken unit test * Update broken unit test * Update broken unit test
nathancoleman
added a commit
that referenced
this pull request
Sep 6, 2024
…lusterRole (#4307) * Remove unnecessary resource permissions in connect-inject ClusterRole * Add changelog entry * Update unit test coverage * Update broken unit test * Update broken unit test * Update broken unit test
nathancoleman
added a commit
that referenced
this pull request
Sep 6, 2024
…lusterRole (#4307) * Remove unnecessary resource permissions in connect-inject ClusterRole * Add changelog entry * Update unit test coverage * Update broken unit test * Update broken unit test * Update broken unit test
nathancoleman
added a commit
that referenced
this pull request
Sep 9, 2024
…ect-inject ClusterRole into release/1.3.x (#4309) NET-10871 Remove unnecessary resource permissions in connect-inject ClusterRole (#4307) * Remove unnecessary resource permissions in connect-inject ClusterRole * Add changelog entry * Update unit test coverage * Update broken unit test * Update broken unit test * Update broken unit test Co-authored-by: Nathan Coleman <[email protected]>
nathancoleman
added a commit
that referenced
this pull request
Sep 9, 2024
…ect-inject ClusterRole into release/1.4.x (#4310) NET-10871 Remove unnecessary resource permissions in connect-inject ClusterRole (#4307) * Remove unnecessary resource permissions in connect-inject ClusterRole * Add changelog entry * Update unit test coverage * Update broken unit test * Update broken unit test * Update broken unit test Co-authored-by: Nathan Coleman <[email protected]>
nathancoleman
added a commit
that referenced
this pull request
Sep 9, 2024
…ect-inject ClusterRole into release/1.5.x (#4311) NET-10871 Remove unnecessary resource permissions in connect-inject ClusterRole (#4307) * Remove unnecessary resource permissions in connect-inject ClusterRole * Add changelog entry * Update unit test coverage * Update broken unit test * Update broken unit test * Update broken unit test Co-authored-by: Nathan Coleman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Remove unnecessary permissions for
NamespaceandNoderesources in the connect-inject controller'sClusterRoleHow I've tested this PR
How I expect reviewers to test this PR
Checklist