[NET-7377] Consul ENT tests #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CT ENT tests for all consul resource supporting partition and ns. - bug fix for map keys, keys did not contain partition and ns, so could have been overridden if same key in a different ns and partition is added as a dependency.
- CT ENT tests for all consul resource supporting partition and ns. - bug fix for map keys, keys did not contain partition and ns, so could have been overridden if same key in a different ns and partition is added as a dependency.
- CT ENT tests for all consul resource supporting partition and ns. - bug fix for map keys, keys did not contain partition and ns, so could have been overridden if same key in a different ns and partition is added as a dependency.
- CT ENT tests for all consul resource supporting partition and ns. - bug fix for map keys, keys did not contain partition and ns, so could have been overridden if same key in a different ns and partition is added as a dependency.
- CT ENT tests for all consul resource supporting partition and ns. - bug fix for map keys, keys did not contain partition and ns, so could have been overridden if same key in a different ns and partition is added as a dependency.
- CT ENT tests for all consul resource supporting partition and ns. - bug fix for map keys, keys did not contain partition and ns, so could have been overridden if same key in a different ns and partition is added as a dependency.
- CT ENT tests for all consul resource supporting partition and ns. - bug fix for map keys, keys did not contain partition and ns, so could have been overridden if same key in a different ns and partition is added as a dependency.
- CT ENT tests for all consul resource supporting partition and ns. - bug fix for map keys, keys did not contain partition and ns, so could have been overridden if same key in a different ns and partition is added as a dependency.
- CT ENT tests for all consul resource supporting partition and ns. - bug fix for map keys, keys did not contain partition and ns, so could have been overridden if same key in a different ns and partition is added as a dependency.
tauhid621
reviewed
Feb 19, 2024
- CT ENT tests for all consul resource supporting partition and ns. - bug fix for map keys, keys did not contain partition and ns, so could have been overridden if same key in a different ns and partition is added as a dependency.
tauhid621
approved these changes
Feb 19, 2024
- CT ENT tests for all consul resource supporting partition and ns. - bug fix for map keys, keys did not contain partition and ns, so could have been overridden if same key in a different ns and partition is added as a dependency.
- CT ENT tests for all consul resource supporting partition and ns. - bug fix for map keys, keys did not contain partition and ns, so could have been overridden if same key in a different ns and partition is added as a dependency.
lkysow
reviewed
Feb 20, 2024
| } | ||
| if d.namespace != "" { | ||
| name = name + "@ns=" + d.namespace | ||
| } |
There was a problem hiding this comment.
@kkavish good find, I think we need to add d.peer as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: