fix: add quiescenceRun flag to avoid render loops #2010
+125
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When quiescence is configured and there are multiple templates, they will trigger eachothers quiescence timers indefinitely. This can be avoided by not ticking the timer of other templates when an individual template's timer fires.
tgross
reviewed
Dec 12, 2024
There was a problem hiding this comment.
This looks like the right design @mismithhisler. Is it feasible to add tests to demonstrate the bad behavior and the fix?
If this looks like it's in the ballpark, I think adding a test should be feasible. |
|
@tgross I've added a unit test for this behavior. If you remove the logic for checking |
mismithhisler
force-pushed
the
fix-quiescence-timer-cycle
branch
from
96ff8f5 to
0e787aa
Compare
tgross
previously approved these changes
Dec 12, 2024
|
Is there any ETA for merge and release on this one? |
|
@Esity We're working on getting this merged, no ETA at the moment but I'll try to keep this updated. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When quiescence is configured and there are multiple templates, they will trigger eachothers quiescence timers indefinitely. This can be avoided by not ticking the timer of other templates when an individual template's timer fires.
Fixes: GH #1427, GH #20618