-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: relocate Consul capacity planning page from waf/ to docs/ #21088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work converting this page using our content templates as a guide.
Please implement the suggested changes and then read through the page again. Then I'll review again for final approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve once @boruszak suggestions are added.
Co-authored-by: Jeff Boruszak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excellent work.
I left suggestions to correct typos and other style issues. The only thing that's not a suggestion to accept is my comment about using code font and linking out for the lists of metrics.
Approving so you're not blocked.
Co-authored-by: Jeff Boruszak <[email protected]>
Description
Do not merge until the following related PR is approved and ready for merge:
https://github.com/hashicorp/tutorials/pull/2091
Moving the Consul capacity planning page from WAF/ to docs/ in the shape of an Overview template page.
Testing & Reproduction steps
None
Links
PR Checklist