Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Changed log level for retryable error Scenarios into release/1.20.x #22142

Open
wants to merge 3 commits into
base: release/1.20.x
Choose a base branch
from

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #22141 to be assessed for backporting due to the inclusion of the label backport/1.20.

The below text is copied from the body of the original PR.


1- xDS DeltaDiscoveryRequest context cancelled set to INFO on stream cancelled as it is retrieable
2- subscription failed logging on ACL change is set to INFO as is also retriable

Description

For an enterprise ask as referred in an internal JIRA ticket.

Testing & Reproduction steps

Testing reproduction done -
1 - created a new build with consul changes in local and container image with binary.
2 - used the new image to start consul server with dev-binary inside a kind cluster
3 - start a service and shut down a service to see the above logs.
4 - Since only ACL change occurred and context cancelled are being handled currently with the corresponding understanding that they are retriable, others are cases will still be in error level .
5- As you can see in the last three lines - to get INFO level lines. run a consul server and try to shut down a service
6 - check that these log lines appear as INFO level

2025-02-07T13:33:08.027Z [INFO] agent.envoy: Error receiving new DeltaDiscoveryRequest; closing request channel: error="rpc error: code = Canceled desc = context canceled"

2025-02-07T13:33:14.026Z [INFO] agent.proxycfg.server-data-sources: subscribe call failed: err="subscription closed by server, ACL change occurred" failure_count=1 key=mesh topic=MeshConfig

2025-02-07T13:33:14.026Z [INFO] agent.proxycfg.server-data-sources: subscribe call failed: err="subscription closed by server, ACL change occurred" failure_count=1 topic=JWTProvider wildcard_subject=true

Links

Related past PR - #20876

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants