Skip to content

Commit

Permalink
chore: Revert mobile menu breakpoint changes/update canary
Browse files Browse the repository at this point in the history
Move panel to the left to avoid issues with cutoff instead of changing the breakpoint
  • Loading branch information
EnMod committed Sep 9, 2024
1 parent 2c12856 commit e8809fb
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 10 deletions.
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"@hashicorp/react-alert-banner": "^7.1.0",
"@hashicorp/react-button": "^6.3.1",
"@hashicorp/react-code-block": "^6.7.0",
"@hashicorp/react-components": "^0.0.0-canary.b79ea47",
"@hashicorp/react-components": "^0.0.0-canary.b8785bd",
"@hashicorp/react-consent-manager": "^9.3.0",
"@hashicorp/react-content": "^8.3.0",
"@hashicorp/react-design-system-components": "0.0.0-nightly.05f1ad1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@
border-bottom-right-radius: 6px;
box-shadow: var(--token-elevation-higher-box-shadow);
min-width: max-content;
position: absolute;
position: fixed;
left: 24px;
}

.dropdownContainerInner {
Expand Down
2 changes: 1 addition & 1 deletion src/contexts/mobile-menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { useNoScrollBody } from 'hooks/use-no-scroll-body'
/**
* Should correspond to --dev-dot-hide-mobile-menu
*/
const DEFAULT_NAV_HEADER_DESKTOP_WIDTH = 1230
const DEFAULT_NAV_HEADER_DESKTOP_WIDTH = 924

interface MobileMenuContextState {
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
--tablet-width-breakpoint: 1000px;

/** Should correspond to --dev-dot-hide-mobile-menu */
--mobile-menu-breakpoint: 1230px;
--mobile-menu-breakpoint: 924px;

/* Font overwrites */
--font-body: var(--token-typography-font-stack-text);
Expand Down
4 changes: 2 additions & 2 deletions src/styles/custom-media.css
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@
@custom-media --dev-dot-sidecar-up only screen and (min-width: 1280px);

/* Search for "Should correspond to --dev-dot-hide-mobile-menu" when changing */
@custom-media --dev-dot-show-mobile-menu (max-width: 1229px);
@custom-media --dev-dot-hide-mobile-menu (min-width: 1230px);
@custom-media --dev-dot-show-mobile-menu (max-width: 923px);
@custom-media --dev-dot-hide-mobile-menu (min-width: 924px);

0 comments on commit e8809fb

Please sign in to comment.