Add site verificaiton meta tag for AHREF service. #2519
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
| @@ -108,6 +108,10 @@ export default function HeadMetadata(props: HeadMetadataProps) { | |||
| name="google-site-verification" | |||
| content="zRQZqfAsOX-ypXfU0mzAIzb5rUvj5fA4Zw2jWJRN-JI" | |||
| /> | |||
| <meta | |||
| name="ahrefs-site-verification" | |||
| content="9d739b21c466a84dae91df1c79396081a9072152e64f765c9390fed6f249fb84" | |||
There was a problem hiding this comment.
This is alright for now, but long term we should have all of these in some sort of config file.
There was a problem hiding this comment.
@aaronvanderlip @RubenSandwich Should this live in https://github.com/hashicorp/hc-centralized-dns? I see other google-site-verifications there.
I'd ask someone on CloudSec for confirmation, but I wonder if putting it here would then verify Developer and .com in one go: https://github.com/hashicorp/hc-centralized-dns/blob/main/terraform/active_domains/hashicorp_com/route53_records.tf
There was a problem hiding this comment.
@kaitlynnefuery ahref wants proof that you own the domain and provides a number of ways to go about it. For this task I chose a verification system that I could control more directly, adding meta tag to a front end file vs a system that I don't control directly, DNS.
There is also <meta name="google-site-verification" content="zRQZqfAsOX-ypXfU0mzAIzb5rUvj5fA4Zw2jWJRN-JI"> currently in the HEAD element so we historically don't seem to have settled on a method.
There was a problem hiding this comment.
I would actually prefer for these values to be in our base config file. Specifically I mean moving all of our site verification keys to it; zd-site-verification, google-site-verification, ahrefs-site-verification.
Though it's a low priority to me because so far we are keeping these all in one file.
🔗 Relevant links
🗒️ What
Adding a verification meta
🤷 Why
This change will enable additional reporting options in the aref tool.
🛠️ How
📸 Design Screenshots
🧪 Testing
💭 Anything else?