refactor: Support light mode in nav #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
nandereck
approved these changes
Jul 23, 2024
Comment on lines
103
to
115
| /* @nest html[data-theme='light'] & { | ||
| &:active { | ||
| background-color: var(--token-color-foreground-primary); | ||
| } | ||
| } | ||
| } */ | ||
|
|
||
| @nest html[data-theme='dark'] & { | ||
| /* @nest html[data-theme='dark'] & { | ||
| color: var(--token-color-foreground-strong); | ||
|
|
||
| &:hover, &[aria-expanded='true'] { | ||
| border-color: var(--token-color-border-strong); | ||
| } | ||
| } | ||
| } */ |
There was a problem hiding this comment.
Why do we need to comment this code out?
There was a problem hiding this comment.
Oh, I was testing whether we needed that code, and left that in before review 😅 I'll double-check what's needed from it and remove in the next commit if I can (I should be able to) 👍
There was a problem hiding this comment.
@nandereck Removed the comments as of this commit (they were safe to remove):
eaf25cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Relevant links
🗒️ What
This PR refactors the nav and relevant children components to support light mode.
🤷 Why
This comes after a design team recommendation while working on other changes to the nav.
🛠️ How
My approach here was to leverage our existing tokens' ability to change based on the site theme, and use those tokens instead of hardcoded values in key areas. In some instances (e.g.: the
.siteLogoSVG on the homepage and the logo on product pages), I addedpathfill overrides to change the SVGs' color when the theme changes.📸 Design Screenshots
There is no established spec for light mode at present; the preview has been approved by design.
🧪 Testing
💭 Anything else?
This work does change which text colors show up when switching to dark mode, but now the colors should be more aligned with our general design system.