Add back in new cert image and fix background color #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6ba4967.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
RubenSandwich
requested review from
EnMod,
a team and
mikegolus
and removed request for
EnMod and
a team
RubenSandwich
commented
Jul 29, 2024
| @@ -19,7 +19,6 @@ | |||
| } | |||
|
|
|||
| @nest html[data-theme='dark'] & { | |||
| background-color: var(--token-color-foreground-high-contrast); | |||
There was a problem hiding this comment.
This was no longer necessary.
RubenSandwich
deleted the
revert-2521-revert-2520-rn/feat/new-homepage-cert-badge-two
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Relevant links
🗒️ What
This is a continuation of the work in #2425, expect this now adds the certification card background. (Which wasn't ready when the other PR started.)
🧪 Testing
Check the new certification background image on the new homepage to make sure they match the new design (not pixel perfect) in the following breakpoints:
Check both light mode and dark mode and make sure it matches the design