Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove onboarding code as all onboarding tutorials have been deprecated #2526

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

heatlikeheatwave
Copy link
Collaborator

@heatlikeheatwave heatlikeheatwave commented Jul 26, 2024

🗒️ What

  • removing onboarding related code as the onboarding tutorials have been deprecated

🧪 Testing

  • See that all onboarding tutorials have been deprecated here
  • See that no valid onboarding pages have been visited here
    • if you visit the few pages listed, you will see they already return 404s

@heatlikeheatwave heatlikeheatwave self-assigned this Jul 26, 2024
Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 7:24pm

Copy link

github-actions bot commented Jul 26, 2024

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@heatlikeheatwave heatlikeheatwave requested review from a team and RubenSandwich and removed request for a team July 26, 2024 21:53
Comment on lines -19 to -26
const sectionOptionsWithLandingPage = Object.values(SectionOption).filter(
(option: SectionOption) => option !== SectionOption.onboarding
)
const sectionOptions = sectionOptionsWithLandingPage.map(
(slug: SectionOption) => `${slug}`
)

return [...activeSlugs, ...sectionOptions]
Copy link
Collaborator Author

@heatlikeheatwave heatlikeheatwave Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see in src/lib/learn-client/types.ts that onboarding is no longer part of the SectionOption enum

Copy link
Collaborator

@RubenSandwich RubenSandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍🏻

@heatlikeheatwave heatlikeheatwave merged commit 7e56142 into main Jul 29, 2024
9 checks passed
@heatlikeheatwave heatlikeheatwave deleted the heat/chore/remove-onboarding branch July 29, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants