Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change sourcemap to hidden #2529

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

heatlikeheatwave
Copy link
Collaborator

🗒️ What

  • change devtool value to hidden-source-map to fix 404 error

Before

Screenshot 2024-07-29 at 19 44 08

After

Screenshot 2024-07-29 at 19 36 07
(no sourcemap found instead of 404)

Testing

  • visit this page
  • open console and wait for error Uncaught Error: This is a new test error thrown after 5 seconds to appear
  • visit rum error logs here
  • You should see an error log matching your timestamp

@heatlikeheatwave heatlikeheatwave self-assigned this Jul 29, 2024
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 2:33pm

Copy link

github-actions bot commented Jul 29, 2024

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

}, 5000)

return () => clearTimeout(timer) // Cleanup the timer on component unmount
}, [])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but let's remove this before merging.

Copy link
Collaborator

@RubenSandwich RubenSandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@heatlikeheatwave heatlikeheatwave merged commit 0f020ae into main Jul 30, 2024
9 checks passed
@heatlikeheatwave heatlikeheatwave deleted the heat/chore/fix-sourcemap-404 branch July 30, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants