Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix package-lock and specific next version for @hashicorp/react-components #2566

Merged

Conversation

heatlikeheatwave
Copy link
Collaborator

@heatlikeheatwave heatlikeheatwave commented Sep 10, 2024

Fixes package-lock issues and adds specific versions of next for react-components required for new nav panel.

@heatlikeheatwave heatlikeheatwave self-assigned this Sep 10, 2024
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 9:41pm

@heatlikeheatwave heatlikeheatwave changed the base branch from feat/use-shared-dropdown-panel to main September 10, 2024 20:55
Copy link

github-actions bot commented Sep 10, 2024

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@heatlikeheatwave heatlikeheatwave changed the base branch from main to feat/use-shared-dropdown-panel September 10, 2024 21:27
Copy link
Contributor

@EnMod EnMod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending successful deploy preview! Thanks @heatlikeheatwave 🎉

@heatlikeheatwave heatlikeheatwave merged commit 52dd33b into feat/use-shared-dropdown-panel Sep 10, 2024
5 of 6 checks passed
@heatlikeheatwave heatlikeheatwave deleted the heat/fix-package-lock branch September 10, 2024 21:35
EnMod added a commit that referenced this pull request Sep 10, 2024
* chore: Install react-components

* refactor: Get the shared dropdown in the nav

Soon to come: Placing the shared dropdown panel in NavigationHeaderDropdownMenu's modal

* refactor: Fit the panel inside the dropdown

- Restore original dropdown usage with new props
- Add support for the product panel as a separate dropdown
- Adjust types/type imports

* chore: Spacing formatting for package-lock.json

* chore: CSS fixes

- Replace mobile menu with panel
- Hack in fixes for mobile
- Fix width on tablet/desktop

* chore: Update canary

* chore: CSS tweaks

* chore: Pass in the data

* chore: Update canary

* chore: Add to desktop

* feat: Add side panel content via updated canary

* chore: Update to latest stable

* upgrade package and breakpoints

* remove home page tutorials link

* add web-mktg-logos dependency

* chore: Update padding to only target the auth menu on generic pages

* chore: Address feedback link padding

* update breakpoints

* refactor: Update canary/reorder items

* chore: Use latest stable panel

* chore: Revert override change

* feat: Support className in MobileAuthenticationControls

* chore: Tweak bottom margin of auth controls

* update MobileAuthControls type

* package upgrade and small padding change

* chore: Use latest @hashicorp/react-components

* update react-components package and adjust product data

* chore: Update package to latest canary

* feat: Close dropdown with Esc

* chore: Change navbarlist child root to NavigationMenu.List

* fix: onEscKeyDown behavior

* chore: Revert mobile menu breakpoint changes/update canary

Move panel to the left to avoid issues with cutoff instead of changing the breakpoint

* chore: Update canary

* chore: Update panel to latest stable

* fix: absolute positioning with hardcoded `left`

* chore: Explicit padding on mobileMenuAuthContainer

Co-authored-by: Heat Hamilton <[email protected]>

* chore: Remove web-mktg-logos dep

* chore: fix package-lock and specific next version for @hashicorp/react-components (#2566)

Update package-lock and include specific next version for react-components

---------

Co-authored-by: Leah Bush <[email protected]>
Co-authored-by: Leah Bush <[email protected]>
Co-authored-by: Heat Hamilton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants