-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix package-lock and specific next version for @hashicorp/react-components #2566
Merged
heatlikeheatwave
merged 1 commit into
feat/use-shared-dropdown-panel
from
heat/fix-package-lock
Sep 10, 2024
Merged
chore: fix package-lock and specific next version for @hashicorp/react-components #2566
heatlikeheatwave
merged 1 commit into
feat/use-shared-dropdown-panel
from
heat/fix-package-lock
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
heatlikeheatwave
changed the base branch from
feat/use-shared-dropdown-panel
to
main
September 10, 2024 20:55
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
heatlikeheatwave
changed the base branch from
main
to
feat/use-shared-dropdown-panel
September 10, 2024 21:27
heatlikeheatwave
force-pushed
the
heat/fix-package-lock
branch
from
September 10, 2024 21:30
61a78af
to
1d9fab4
Compare
EnMod
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending successful deploy preview! Thanks @heatlikeheatwave 🎉
heatlikeheatwave
merged commit Sep 10, 2024
52dd33b
into
feat/use-shared-dropdown-panel
5 of 6 checks passed
EnMod
added a commit
that referenced
this pull request
Sep 10, 2024
* chore: Install react-components * refactor: Get the shared dropdown in the nav Soon to come: Placing the shared dropdown panel in NavigationHeaderDropdownMenu's modal * refactor: Fit the panel inside the dropdown - Restore original dropdown usage with new props - Add support for the product panel as a separate dropdown - Adjust types/type imports * chore: Spacing formatting for package-lock.json * chore: CSS fixes - Replace mobile menu with panel - Hack in fixes for mobile - Fix width on tablet/desktop * chore: Update canary * chore: CSS tweaks * chore: Pass in the data * chore: Update canary * chore: Add to desktop * feat: Add side panel content via updated canary * chore: Update to latest stable * upgrade package and breakpoints * remove home page tutorials link * add web-mktg-logos dependency * chore: Update padding to only target the auth menu on generic pages * chore: Address feedback link padding * update breakpoints * refactor: Update canary/reorder items * chore: Use latest stable panel * chore: Revert override change * feat: Support className in MobileAuthenticationControls * chore: Tweak bottom margin of auth controls * update MobileAuthControls type * package upgrade and small padding change * chore: Use latest @hashicorp/react-components * update react-components package and adjust product data * chore: Update package to latest canary * feat: Close dropdown with Esc * chore: Change navbarlist child root to NavigationMenu.List * fix: onEscKeyDown behavior * chore: Revert mobile menu breakpoint changes/update canary Move panel to the left to avoid issues with cutoff instead of changing the breakpoint * chore: Update canary * chore: Update panel to latest stable * fix: absolute positioning with hardcoded `left` * chore: Explicit padding on mobileMenuAuthContainer Co-authored-by: Heat Hamilton <[email protected]> * chore: Remove web-mktg-logos dep * chore: fix package-lock and specific next version for @hashicorp/react-components (#2566) Update package-lock and include specific next version for react-components --------- Co-authored-by: Leah Bush <[email protected]> Co-authored-by: Leah Bush <[email protected]> Co-authored-by: Heat Hamilton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes package-lock issues and adds specific versions of next for
react-components
required for new nav panel.