refactor: Add new dropdown to non-generic pages #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move `left` alignment of dropdowns exclusively into desktop dropdown pane - Add `NavBarListContainer` to tutorials dropdown wrapping to satisfy Radix
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EnMod
changed the title
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 Seventy-four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
This reverts commit 393b625.
EnMod
changed the title
This reverts commit 46a6c5d.
EnMod
commented
Sep 12, 2024
Comment on lines
+33
to
+35
| .homepageDropdownPane { | ||
| left: -216px; | ||
| } |
There was a problem hiding this comment.
Isolates this adjustment to just the homepage dropdown, instead of having it affect all dropdowns across the site.
src/components/navigation-header/components/product-page-content/index.tsx
Show resolved
Hide resolved
| return <ul className={s.navList}>{children}</ul> | ||
| type NativeDivElement = JSX.IntrinsicElements['div'] | ||
|
|
||
| export default function SidebarNavList({ |
There was a problem hiding this comment.
Allows per-instance control of SidebarNavList styles. Needed for a padding adjustment for product page resources sections here:
EnMod
requested review from
a team,
LeahMarieBush,
RubenSandwich and
heatlikeheatwave
and removed request for
a team
Co-authored-by: Heat Hamilton <[email protected]>
heatlikeheatwave
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Relevant links
🗒️ What
This PR follows up #2553 by replacing all existing instances of the old nav dropdown list with the new panel
🛠️ How
This PR replaces the existing list-like panel in desktop/mobile layouts with the new shared panel. This change affects product pages,
/profile/*pages, and the page at/tutorial/library.📸 Design Screenshots
🧪 Testing