Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add version selector back to release notes pages #2570

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

heatlikeheatwave
Copy link
Collaborator

@heatlikeheatwave heatlikeheatwave commented Sep 11, 2024

πŸ”— Relevant links

πŸ—’οΈ What

  • TFE ed team requested version selector be added back to release notes pages

🀷 Why

πŸ› οΈ How

  • reverted previous changes that removed version dropdown from release notes page. See PR here

πŸ§ͺ Testing

TFE

  • Visit TFE docs landing page

  • Version dropdown should be visible

  • Visit TFE release notes page for a specific version

  • Version dropdown should be visible

  • Navigate to any page in the sidebar

  • Version dropdown should be visible on that page

Vault

  • Navigate to versioned release notes page
  • Version dropdown should be visible.
  • Navigate to any other page (that is not a versioned release notes page), such as the release notes landing page
  • Version dropdown should be visible

Versioned TFE 404 page

  • Navigate to this page
  • Page should contain the text "This page does not exist for version v202210-1."

@heatlikeheatwave heatlikeheatwave self-assigned this Sep 11, 2024
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
dev-portal βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 12, 2024 5:07pm

Copy link

github-actions bot commented Sep 11, 2024

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

This PR introduced no changes to the javascript bundle πŸ™Œ

@heatlikeheatwave heatlikeheatwave requested review from a team and nandereck and removed request for a team September 11, 2024 21:08
Copy link
Contributor

@nandereck nandereck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸ…

@heatlikeheatwave heatlikeheatwave merged commit f4ef779 into main Sep 12, 2024
9 checks passed
@heatlikeheatwave heatlikeheatwave deleted the heat/remove-version-dropdown branch September 12, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants