Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HCP Vagrant Box Registry API docs #2572

Merged
merged 2 commits into from
Sep 13, 2024
Merged

add HCP Vagrant Box Registry API docs #2572

merged 2 commits into from
Sep 13, 2024

Conversation

zchsh
Copy link
Contributor

@zchsh zchsh commented Sep 12, 2024

πŸ”— Relevant links

πŸ—’οΈ What

Adds HCP Vagrant Box Registry API docs to /hcp/api-docs/vagrant-box-registry.

πŸ› οΈ How

Sources OpenAPI JSON specs from https://github.com/hashicorp/hcp-specs/tree/main/specs/cloud-vagrant-box-registry, and renders them with the existing OpenAPI docs template.

πŸ“Έ Design Screenshot

dev-portal-git-zshcp-vagrant-api-docs-hashicorp vercel app_hcp_api-docs_vagrant-box-registry

πŸ§ͺ Testing

πŸ’­ Anything else?

Sidebar is a bit rough

Upstream in the spec file, authors could add tag values to more intentionally group operations. For an example of this, see the HCP Consul spec file, and the resulting HCP Consul docs.

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
dev-portal βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 13, 2024 5:58pm

Copy link

github-actions bot commented Sep 12, 2024

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/hcp/api-docs/vagrant-box-registry/[[...page]] 157.43Β KB 365.28Β KB

@zchsh zchsh marked this pull request as ready for review September 12, 2024 14:13
@zchsh zchsh requested review from a team, pbortnick and chrisroberts and removed request for a team September 12, 2024 14:13
@chrisroberts
Copy link
Member

Just as a note: sidebar content was discussed previously with @zchsh and he provided options and examples for how we can make adjustments in our proto generation to address it (links noted in description). Those updates should be applied at some point next week.

Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰

@zchsh zchsh enabled auto-merge (squash) September 13, 2024 17:56
@zchsh zchsh merged commit fa0e92e into main Sep 13, 2024
6 checks passed
@zchsh zchsh deleted the zs.hcp-vagrant-api-docs branch September 13, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants