Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vault Auth method #281

Merged
merged 9 commits into from
Jul 1, 2022
Merged

Conversation

Kryvchun
Copy link
Contributor

@Kryvchun Kryvchun commented May 13, 2022

This PR adds support for vault Kubernetes authentication.

Issue: #274.

New parameters:

  -vault-k8s-auth-role-name
      Enable k8s auth method and use this role name

  -vault-k8s-service-account-token
      Use this service token for the k8s auth method

  -vault-k8s-service-account-token-path
      Use the service token from the file for the k8s auth method

  -vault-k8s-service-mount-path
      Use this login mount path for the k8s auth method

@Kryvchun Kryvchun requested a review from a team May 13, 2022 13:13
@Kryvchun Kryvchun marked this pull request as draft May 13, 2022 13:13
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kryvchun Kryvchun marked this pull request as ready for review June 8, 2022 06:18
@Kryvchun Kryvchun changed the title WIP: Support Vault Auth method Support Vault Auth method Jun 8, 2022
@Kryvchun
Copy link
Contributor Author

@eikenb Hi, it is ready for review.

@eikenb eikenb added this to the v0.13.0 milestone Jun 30, 2022
@eikenb
Copy link
Contributor

eikenb commented Jun 30, 2022

With the release of consul-template 0.29.1 that included the changes needed for this and the dependency has already been updated.

IE. I'll be reviewing this soon for inclusion in 0.13.0.

.gitignore Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@eikenb eikenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the one change (.gitignore) this looks good.

Thanks!

@Kryvchun
Copy link
Contributor Author

Kryvchun commented Jul 1, 2022

@eikenb
.gitignore fixed and main merged.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants