Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug in prefix and suffix check using filepath #78

Merged
merged 8 commits into from
Jan 27, 2025
Merged

fix: bug in prefix and suffix check using filepath #78

merged 8 commits into from
Jan 27, 2025

Conversation

dduzgun-security
Copy link
Collaborator

@dduzgun-security dduzgun-security commented Jan 24, 2025 •
edited
Loading

Alternative to #77 but using"path/filepath" instead of strings.
Resolves a bug where the prefix check doesn't work on empty path.

Testing with real tarballs (ref)

@dduzgun-security dduzgun-security requested a review from a team as a code owner January 24, 2025 20:13
eastebry
eastebry previously approved these changes Jan 27, 2025
View reviewed changes
alanpchua
alanpchua approved these changes Jan 27, 2025
View reviewed changes
Copy link

@alanpchua alanpchua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dduzgun-security
Copy link
Collaborator Author

@hashicorp/team-ip-compliance when you get some time a review would be appreciated 🙏

@dduzgun-security dduzgun-security enabled auto-merge (squash) January 27, 2025 22:24
@dduzgun-security dduzgun-security merged commit d8b1ee7 into main Jan 27, 2025
9 checks passed
@dduzgun-security dduzgun-security deleted the fix/extraction-check-bug-using-filepath branch January 27, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanpchua alanpchua alanpchua approved these changes

@james-warren0 james-warren0 james-warren0 approved these changes

@picatz picatz picatz approved these changes

@lafentres lafentres lafentres approved these changes

@eastebry eastebry eastebry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dduzgun-security @eastebry @lafentres @picatz @james-warren0 @alanpchua