Add AllowMemberTokenManagement to Team #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliannatetreault
force-pushed
the
juliannatetreault/TF-16199-add-team-token-management
branch
from
a7e2b3f
to
bbcc300
Compare
2 tasks
juliannatetreault
force-pushed
the
juliannatetreault/TF-16199-add-team-token-management
branch
2 times, most recently
from
598e311
to
00fda13
Compare
emlanctot
reviewed
Jul 8, 2024
JarrettSpiker
previously approved these changes
Jul 15, 2024
emlanctot
previously approved these changes
Jul 15, 2024
juliannatetreault
dismissed stale reviews from emlanctot and JarrettSpiker
via
19b3a1a
juliannatetreault
force-pushed
the
juliannatetreault/TF-16199-add-team-token-management
branch
from
c6e08b7
to
19b3a1a
Compare
juliannatetreault
force-pushed
the
juliannatetreault/TF-16199-add-team-token-management
branch
from
19b3a1a
to
037fcab
Compare
juliannatetreault
force-pushed
the
juliannatetreault/TF-16199-add-team-token-management
branch
from
635287f
to
9c996d7
Compare
brandonc
approved these changes
Jul 30, 2024
JarrettSpiker
approved these changes
Jul 31, 2024
juliannatetreault
deleted the
juliannatetreault/TF-16199-add-team-token-management
branch
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new team permission -
AllowMemberTokenManagement- to theTeamblock.AllowMemberTokenManagementistrueby default and can only be managed by Owners or users with "Manage Teams" permissions.Additionally, this PR adds tests for the new permission.
Testing plan
AllowMemberTokenManagementistrueby default when Teams are created.AllowMemberTokenManagementis read for Teams.AllowMemberTokenManagementis updatable for Teams.External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.