-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Stacks, StackPlans support #934
More Stacks, StackPlans support #934
Conversation
type StackConfigurationStatusTimestamps struct { | ||
QueuedAt *time.Time `jsonapi:"attr,queued-at,omitempty,rfc3339"` | ||
CompletedAt *time.Time `jsonapi:"attr,completed-at,omitempty,rfc3339"` | ||
PreparingAt *time.Time `jsonapi:"attr,preparing-at,omitempty,rfc3339"` | ||
EnqueueingAt *time.Time `jsonapi:"attr,enqueueing-at,omitempty,rfc3339"` | ||
CanceledAt *time.Time `jsonapi:"attr,canceled-at,omitempty,rfc3339"` | ||
ErroredAt *time.Time `jsonapi:"attr,errored-at,omitempty,rfc3339"` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the more constrained format rfc3339
and not iso8601
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all practical purposes, the API emits dates that fits both formats. For the purposes of parsing dates from HCP Terraform, they should be equivalent. RFC3339 is the slightly more stringent version so I usually choose it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits
return | ||
} | ||
|
||
func TestStackConverged(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
I was unable to add meaningful tests yet but plan to backfill them later once the GAP on staging is able to execute stack operations once again.