More Stacks, StackPlans support #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebasslash
reviewed
Jul 16, 2024
sebasslash
reviewed
Jul 16, 2024
Comment on lines
+101
to
+108
| type StackConfigurationStatusTimestamps struct { | ||
| QueuedAt *time.Time `jsonapi:"attr,queued-at,omitempty,rfc3339"` | ||
| CompletedAt *time.Time `jsonapi:"attr,completed-at,omitempty,rfc3339"` | ||
| PreparingAt *time.Time `jsonapi:"attr,preparing-at,omitempty,rfc3339"` | ||
| EnqueueingAt *time.Time `jsonapi:"attr,enqueueing-at,omitempty,rfc3339"` | ||
| CanceledAt *time.Time `jsonapi:"attr,canceled-at,omitempty,rfc3339"` | ||
| ErroredAt *time.Time `jsonapi:"attr,errored-at,omitempty,rfc3339"` | ||
| } |
There was a problem hiding this comment.
Why the more constrained format rfc3339 and not iso8601?
There was a problem hiding this comment.
For all practical purposes, the API emits dates that fits both formats. For the purposes of parsing dates from HCP Terraform, they should be equivalent. RFC3339 is the slightly more stringent version so I usually choose it
Uk1288
reviewed
Jul 18, 2024
Uk1288
reviewed
Jul 18, 2024
| return | ||
| } | ||
|
|
||
| func TestStackConverged(t *testing.T) { |
Uk1288
previously approved these changes
Jul 18, 2024
sebasslash
approved these changes
Jul 19, 2024
brandonc
deleted the
TF-18387-stacks-configuration-deployment-support-in-go-tfe
branch
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to add meaningful tests yet but plan to backfill them later once the GAP on staging is able to execute stack operations once again.