Skip to content

support TraverseSplat for hclwrite.TokensForTraversal #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support TraverseSplat for hclwrite.TokensForTraversal #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions hclwrite/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,21 @@ func appendTokensForTraversalStep(step hcl.Traverser, toks Tokens) Tokens {
Type: hclsyntax.TokenCBrack,
Bytes: []byte{']'},
})
case hcl.TraverseSplat:
toks = append(toks,
&Token{
Type: hclsyntax.TokenOBrack,
Bytes: []byte{'['},
},
&Token{
Type: hclsyntax.TokenStar,
Bytes: []byte{'*'},
},
&Token{
Type: hclsyntax.TokenCBrack,
Bytes: []byte{']'},
},
)
default:
panic(fmt.Sprintf("unsupported traversal step type %T", step))
}
Expand Down
4 changes: 4 additions & 0 deletions hclwrite/generate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,7 @@ func TestTokensForTraversal(t *testing.T) {
hcl.TraverseRoot{Name: "root"},
hcl.TraverseAttr{Name: "attr"},
hcl.TraverseIndex{Key: cty.StringVal("index")},
hcl.TraverseSplat{},
},
Tokens{
{Type: hclsyntax.TokenIdent, Bytes: []byte("root")},
Expand All @@ -516,6 +517,9 @@ func TestTokensForTraversal(t *testing.T) {
{Type: hclsyntax.TokenQuotedLit, Bytes: []byte("index")},
{Type: hclsyntax.TokenCQuote, Bytes: []byte(`"`)},
{Type: hclsyntax.TokenCBrack, Bytes: []byte{']'}},
{Type: hclsyntax.TokenOBrack, Bytes: []byte{'['}},
{Type: hclsyntax.TokenStar, Bytes: []byte("*")},
{Type: hclsyntax.TokenCBrack, Bytes: []byte{']'}},
},
},
}
Expand Down
1 change: 0 additions & 1 deletion traversal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,6 @@ func (tn TraverseIndex) SourceRange() Range {
// TraverseSplat applies the splat operation to its initial value.
type TraverseSplat struct {
isTraverser
Each Traversal
SrcRange Range
}

Expand Down