Allow for install of Darwin ARM64 binary #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefAustin
requested review from
a team,
shore and
alvin-huang
and removed request for
a team
|
|
|
Any chance I could get some 👀 on this, @alvin-huang &&|| @shore ? TIA! |
|
Thanks for the PR. While doing some release work for nomad-pack and updating the other Nomad configuration, I spotted this issue and added the arm64 settings to the configuration there. After a local update and a reinstall of levant via brew, it now appears to be vending the ARM64 binaries. I'll close this PR as superseded by #281, but I wanted to say that we appreciate your pointing it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears that as of v0.3.2 y'all started compiling native ARM64 binaries for Darwin so I figured it might help some folks to allow for Homebrew-based installations.