Update the plan command.
#387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgbaker
approved these changes
Dec 1, 2020
| Specify the format of plan to be emitted. Valid values include JSON, DIFF, | ||
| and NDJSON. The default is DIFF. | ||
|
|
||
| -output-to |
There was a problem hiding this comment.
render has a similar config, but it uses the -out:
Line 50 in 19af3df
| is currently set in a running job. | ||
| is currently set in a running job. | ||
|
|
||
| -output-format |
There was a problem hiding this comment.
-output-format is perhaps redundant? maybe just -format?
update: i see that this is drawing a distinction against -log-format... 🤔
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty big PR, but this fixes the levant plan command to output an entire plan in "pretty" mode. Also added some CLI flags to allow the user to specify the output format and where they would like the output to go. I added a CLI mode in case we wanted to bring colors to the party.
I think the JSON -> Lines conversion could probably be made more elegant 💍, but for now it seems to do the right thing. Would like to add some testing for all this too, but I wanted you to start milling over what I'd done thus far.