Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi-column queries #34

Merged
merged 5 commits into from
Dec 19, 2023
Merged

fix: multi-column queries #34

merged 5 commits into from
Dec 19, 2023

Conversation

jimlambrt
Copy link
Collaborator

@jimlambrt jimlambrt commented Dec 19, 2023

fix (parse): queries with multiple columns need to properly handle right-side logic expressions when they are complete expressions (having both a left and right side).

@jimlambrt jimlambrt changed the title fix: fix multi-column select by properly handling right-side fix: multi-column select by properly handling right-side Dec 19, 2023
@jimlambrt jimlambrt force-pushed the jimlambrt-fix-multi-column branch from c7a6bd5 to 883daff Compare December 19, 2023 14:35
@jimlambrt jimlambrt changed the title fix: multi-column select by properly handling right-side fix: multi-column queries Dec 19, 2023
right-side logic expressions when they are complete expressions (having
both a left and right side).
@jimlambrt jimlambrt force-pushed the jimlambrt-fix-multi-column branch from 883daff to 4a6bc8b Compare December 19, 2023 14:38
@jimlambrt jimlambrt requested a review from ZedLi December 19, 2023 14:59
Copy link

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

parser.go Outdated Show resolved Hide resolved
…ndle right-side logic expressions when they are complete expressions (having both a left and right side).
…ndle right-side logic expressions when they are complete expressions (having both a left and right side).
…ndle right-side logic expressions when they are complete expressions (having both a left and right side).
@jimlambrt jimlambrt merged commit 2101c56 into main Dec 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants