Fix podman 5.0 unmarshall error. #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Podman 5.0 API: containers/podman@de845a5. Upstream has an unmarshal API implementation: containers/podman@585af03.
hbsnmyj
requested review from
shoenig,
jrasell,
lgfa29 and
towe75
as code owners
|
|
|
It would be great to get this merged, it appears to be breaking Archlinux Nomad+Podman 5.0 deployments |
shoenig
approved these changes
Apr 15, 2024
|
Time for a new release? |
lukaszo
pushed a commit
to koyeb/nomad-driver-podman
that referenced
this pull request
Jun 4, 2024
New Podman 5.0 API: containers/podman@de845a5. Upstream has an unmarshal API implementation: containers/podman@585af03.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podman 5.0 introduces some inspect API type changes: commit, breaking the unmarshal code. Since we don't use the fields, we just delete them. See Issue #331.
Testing:
Note: