using allocStatusDistribution to ensure service job always has a non-…

…queued alloc
hashicorp · Feb 7, 2025 · 6c59f47 · 6c59f47
1 parent 1ce6e2f
commit 6c59f47
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/ui/tests/acceptance/job-detail-test.js b/ui/tests/acceptance/job-detail-test.js
@@ -305,6 +305,9 @@ moduleForJob(
       type: 'service',
       noActiveDeployment: true,
       withPreviousStableVersion: true,
+      allocStatusDistribution: {
+        running: 1,
+      },
     }),
   {
     'the subnav links to deployment': async (job, assert) => {

diff --git a/ui/tests/helpers/module-for-job.js b/ui/tests/helpers/module-for-job.js
@@ -168,17 +168,12 @@ export default function moduleForJob(
           await switchToHistorical(job);
         }
 
-        if (percySnapshot) {
-          await percySnapshot(`TODO: TEMP: legend item? ${job.type}`);
-        }
-
         // explicitly setting allocationStatusDistribution when creating the job that gets passed here
         // is the best way to ensure we don't end up with an unlinkable "queued" allocation status,
         // but we can be redundant for the sake of future-proofing this here.
         const legendItem = find(
           '.legend li.is-clickable:not([data-test-legend-label="queued"]) a'
         );
-        console.log(`legend item ${job.type}`, legendItem);
 
         const status = legendItem.parentElement.getAttribute(
           'data-test-legend-label'