build: use semgrep to prevent using @latest tags for go install steps #11960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
force-pushed
the
semgrep-tools-versions
branch
from
661cd76 to
0d6e472
Compare
shoenig
force-pushed
the
semgrep-tools-versions
branch
from
0d6e472 to
f26bc17
Compare
shoenig
force-pushed
the
semgrep-tools-versions
branch
from
f26bc17 to
d9bdfb8
Compare
shoenig
force-pushed
the
semgrep-tools-versions
branch
from
d9bdfb8 to
b489a8f
Compare
shoenig
force-pushed
the
semgrep-tools-versions
branch
from
b489a8f to
9c3dcfc
Compare
shoenig
force-pushed
the
semgrep-tools-versions
branch
from
9c3dcfc to
4055f4d
Compare
shoenig
force-pushed
the
semgrep-tools-versions
branch
from
4055f4d to
7e155f8
Compare
shoenig
force-pushed
the
semgrep-tools-versions
branch
from
7e155f8 to
97a6cbb
Compare
Tools should be pinned to a specific dependency when using `make bootstrap` to Go install the tools we use to build Nomad. Using @latest tags means a tool and what it produces could change out from under us.
shoenig
force-pushed
the
semgrep-tools-versions
branch
from
97a6cbb to
72e9d61
Compare
|
|
tgross
added
the
stage/needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools should be pinned to a specific dependency when using
make bootstrapto Go install the tools we use to build Nomad. Using @latest tags means a
tool and what it produces could change out from under us.