Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds support of deployments into system jobs #8841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dubadub
Copy link

@dubadub dubadub commented Sep 8, 2020

Modifies generic scheduler to accommodate System Deployments.

Things left to do:

  • Get rid of code duplication: right now system scheduler copies all the methods from the generic one. Maybe there is a way to reuse methods.
  • Fix failing tests: system scheduler tests weren't updated, pending on proper new system scheduler factory implementation.

Sharing early as I hope to get feedback on this PR from the maintainers.

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 8, 2020

CLA assistant check
All committers have signed the CLA.

@dubadub
Copy link
Author

dubadub commented Sep 8, 2020

Related to #3644

@tgross
Copy link
Member

tgross commented Sep 17, 2020

Hi @dubadub! Just wanted to let you know we're not ignoring you here... this is a big issue and something we had some in-flight work on that's getting delayed. So we want to make sure we give you actionable feedback. We'll try to come back to you here soon. Thanks for your patience!

Base automatically changed from master to main March 8, 2021 19:25
@tgross tgross added the stage/needs-rebase This PR needs to be rebased on main before it can be backported to pick up new BPA workflows label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/needs-discussion stage/needs-rebase This PR needs to be rebased on main before it can be backported to pick up new BPA workflows
Projects
Status: Needs Roadmapping
Development

Successfully merging this pull request may close these issues.

3 participants