Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Lucas Bajolet <[email protected]>
  • Loading branch information
jeinwag and lbajolet-hashicorp committed Jul 7, 2023
1 parent e8b77b2 commit 588d3f2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion builder/proxmox/common/step_start_vm.go
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ func generateProxmoxDisks(disks []diskConfig) proxmox.QemuDevices {
if devs[idx]["type"] == "scsi" || devs[idx]["type"] == "virtio" {
setDeviceParamIfDefined(devs[idx], "iothread", strconv.FormatBool(disks[idx].IOThread))
}
// Proxmox API expectes the value of discard to bei either "off" or "on"
// Proxmox API expects the value of discard to be either "off" or "on"
setDeviceParamIfDefined(devs[idx], "discard", func() string {
if disks[idx].Discard {
return "on"
Expand Down
2 changes: 1 addition & 1 deletion docs/builders/clone.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ or responding to pattern `/dev/.+`. Example:
- `discard` (bool) - Relay TRIM commands to the underlying storage. Defaults
to false.

- `ssd` (bool) - Drive will be represented to the guest as solid-state drive
- `ssd` (bool) - Drive will be presented to the guest as solid-state drive
rather than a rotational disk.

- `template_name` (string) - Name of the template. Defaults to the generated
Expand Down
2 changes: 1 addition & 1 deletion docs/builders/iso.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ or responding to pattern `/dev/.+`. Example:
- `discard` (bool) - Relay TRIM commands to the underlying storage. Defaults
to false.

- `ssd` (bool) - Drive will be represented to the guest as solid-state drive
- `ssd` (bool) - Drive will be presented to the guest as solid-state drive
rather than a rotational disk.

- `template_name` (string) - Name of the template. Defaults to the generated
Expand Down

0 comments on commit 588d3f2

Please sign in to comment.