Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct value for discard parameter when disabled #203

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

jeinwag
Copy link
Contributor

@jeinwag jeinwag commented Jul 10, 2023

Fixes #202.

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this @jeinwag

@lbajolet-hashicorp lbajolet-hashicorp merged commit f581c59 into hashicorp:main Jul 10, 2023
@ol3d
Copy link

ol3d commented Jul 12, 2023

When is an estimated date that these changes will be cut into a release?

@lbajolet-hashicorp
Copy link
Contributor

Hi @ol3d,

I believe we can release a new version of the plugin by next week.

In the meantime, if you want to experiment with the plugin, I suggest you test out the new options with one of the releases built from the latest main, available in https://github.com/hashicorp/packer-plugin-proxmox/actions/runs/5535351316.

Please let us know if something does not behave as documented or expected, we can probably fix it before the release of the plugin.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect flag values for controlling ssd trim behaviour
3 participants