fix for remove the old cloud-init on local disks

[VadimLakt]

When creating an os+db image, Packer throws an error: Error updating template: ide1 - cloud-init drive is already attached at 'ide0'.

The reason is that Packer did not remove the old cloud-init and trying to insert a new one.

If you create cloud-init on local disks, the file name will also include the disk format:

my $scfg = PVE::Storage::storage_config($storecfg, $storeid);
my $name = "vm-$vmid-cloudinit";

    my $fmt = undef;
    if ($scfg->{path}) {
        $fmt = $disk->{format} // "qcow2";
        $name .= ".$fmt";
    } else {
        $fmt = $disk->{format} // "raw";
    }

Closes #273

[hashicorp-cla-app]

All committers have signed the CLA.

[hashicorp-cla-app]

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

---

Vadim Laktyushin seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

_{Have you signed the CLA already but the status is still pending? Recheck it.}

[mizhka]

Hi,

Any progress on it?

[lbajolet-hashicorp]

Hi @VadimLakt,

Thanks for the PR! The code looks good to me, but before merging may I ask how this change fixes the issue at hand?
It's not clear to me what the controller string looks like in the case you describe, I assume there's extra data in there between the cloudinit and the media and that's why it fails with the current check, but I would appreciate if you cloud share what kind of string makes the current check fail and how the new code fixes that.

Thanks again!

[VadimLakt]

Hi @lbajolet-hashicorp,

Thank you for your response.

I apologize for my delayed reply; we had difficulty accessing the problematic server. I added some debugging to the issue area, and the line that fails the check looks like this: var: vmParams[controller] value: "RAID5:154/vm-154-cloudinit.qcow2,media=cdrom,size=4M".

Between "cloudinit" and "media," there is also the disk format "qcow2."

If you need any further adjustments, feel free to let me know!