Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 291]: Handle disk format default #292

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

mpywell
Copy link
Contributor

@mpywell mpywell commented Oct 17, 2024

The proxmox-api-go version used in 1.2.1 now requires a disk format to be passed to it rather than falling back to Proxmox backend defaults when omitted.

Add a default format value of raw in line with previous versions of the plugin

Closes #291

`proxmox-api-go` now requires a disk format to be passed to it rather than falling back to Proxmox backend defaults when left empty.
Add a default value `raw` in line with previous versions of `packer-plugin-proxmox`
@mpywell mpywell requested a review from a team as a code owner October 17, 2024 10:52
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy one, thanks for the fix @mpywell.

LGTM

@lbajolet-hashicorp lbajolet-hashicorp merged commit ec7ac1b into hashicorp:main Oct 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error creating VM: format can only be one of the following values: cow,cloop,qcow,qcow2,qed,vmdk,raw
2 participants