Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: use squashed commit for backports #12646

Closed
wants to merge 1 commit into from

Conversation

lbajolet-hashicorp
Copy link
Contributor

The current setting for applying backports from the main branch to a release branch attempts to pick commits one by one and merge them with a merge commit to the release branch.

This seldom causes an issue where the backport assistant picks-up every commit from the beginning of the release branch, and applies them through one big merge commit, on top of everything else that was already merged into the release branch.

To limit the times it happens, we change how the backport assistant behaves to only apply one squashed commit that contains the changes from the MR into the release branch.

The current setting for applying backports from the main branch to a
release branch attempts to pick commits one by one and merge them with a
merge commit to the release branch.

This seldom causes an issue where the backport assistant picks-up every
commit from the beginning of the release branch, and applies them
through one big merge commit, on top of everything else that was already
merged into the release branch.

To limit the times it happens, we change how the backport assistant
behaves to only apply one squashed commit that contains the changes from
the MR into the release branch.
@lbajolet-hashicorp
Copy link
Contributor Author

EDIT: well that forces using squash-merge in order to support this workflow, which is less than ideal imho, let's not.

Copy link

github-actions bot commented Nov 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant