Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command: remove unused FlagSetFlags enum #12649

Merged
merged 1 commit into from
Oct 16, 2023
Merged

command: remove unused FlagSetFlags enum #12649

merged 1 commit into from
Oct 16, 2023

Conversation

lbajolet-hashicorp
Copy link
Contributor

The enumeration for FlagSetFlags, which presumably was added when the Meta structure was introduced, aims to pre-populate the flagset for a subcommand with a series of arguments.

However, despite it being documented, it is actually not used, and therefore can safely be removed from the codebase.

@lbajolet-hashicorp
command: remove unused FlagSetFlags enum
35f7cab 
The enumeration for FlagSetFlags, which presumably was added when the
Meta structure was introduced, aims to pre-populate the flagset for a
subcommand with a series of arguments.

However, despite it being documented, it is actually not used, and
therefore can safely be removed from the codebase.
@lbajolet-hashicorp lbajolet-hashicorp marked this pull request as ready for review October 6, 2023 14:54
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner October 6, 2023 14:54
nywilken
nywilken approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on removing this. This caught me in the past, when I was wiring up the fix command. There were plans for it but that never happened.

@nywilken nywilken merged commit 020f18e into main Oct 16, 2023
9 checks passed
@nywilken nywilken added the tech-debt Issues and pull requests related to addressing technical debt or improving the codebase label Oct 16, 2023
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
tech-debt Issues and pull requests related to addressing technical debt or improving the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbajolet-hashicorp @nywilken