Dev version show build time #12871
Dev version show build time #12871
Conversation
If defined, the version subcommand will now print the VersionMetadata as part of the version string. This allows us to define data at compile/link time, and show it to users.
The dev target used to report the current version, along with the version's prerelease status. However, the problem was that we had no way to differentiate easily between two locally-built versions of Packer, as the version/prerelease are typically static, which could lead to confusion sometimes. To make it clearer which version of Packer is being used, especially for pre-releases, we're now adding date and time information to the metadata of a development build of Packer.
lbajolet-hashicorp
force-pushed
the
dev_version_show_build_time
branch
from
0b6f7b7 to
8673509
Compare
There was a problem hiding this comment.
As discussed internally. I understand the idea and not opposed to including build time in the version.
But making a change to make dev feels off as it depends on the user actually running make dev and the tooling being in the right place.
If you want to revisit to set the version metadata for builds using Go. I can jump on board because then we have control over that.
You may be able to do something like packer version [-l|--long] to display full version info like
v1.10.s-dev+commitsha
OS: darwin/arm64
BuildDate=2024-01-26T15:54:24Z
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
In order to help differentiate between dev builds of Packer, this change adds a date/time when built as extra version metadata (we reuse this field since it was not referenced anywhere), and change a bit the logic of the
versioncommand so it is reported.