Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make TMPDIR clickable #13244

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

mogrogan
Copy link
Contributor

@mogrogan mogrogan commented Dec 20, 2024

The option is less visible than the other one and by adding the quote,
it creates an anchor that will make it easier to link.

image

Post comment edit:

image

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! I left a small nitpick on the directories described so we can fence them inside backticks for them to be rendered as code, but besides that we're good I think

Pre-approving to not block later

website/content/docs/configure.mdx Outdated Show resolved Hide resolved
The option is less visible than the other one and by adding the quote,
it creates an anchor that will make it easier to link.
@lbajolet-hashicorp lbajolet-hashicorp merged commit 024bf72 into main Dec 23, 2024
12 checks passed
@lbajolet-hashicorp lbajolet-hashicorp added the backport/website Backport PR changes to `stable-website` and latest release branch label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/website Backport PR changes to `stable-website` and latest release branch docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants