This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Added the ability to pass arbitrary headers. #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Updated documentation.
brikis98
reviewed
Aug 14, 2020
| echo -e " --ca-file-path\t\tPath to a PEM-encoded certificate authority used to encrypt and verify authenticity of client and server connections. Will be installed under <install-path>/tls/ca." | ||
| echo -e " --cert-file-path\t\tPath to a PEM-encoded certificate, which will be provided to clients or servers to verify the agent's authenticity. Will be installed under <install-path>/tls. Must be provided along with --key-file-path." | ||
| echo -e " --key-file-path\t\tPath to a PEM-encoded private key, used with the certificate to verify the agent's authenticity. Will be installed under <install-path>/tls. Must be provided along with --cert-file-path" | ||
| echo -e " --help | -h\t\tPrints this usage message." |
There was a problem hiding this comment.
Would you mind moving the single-param options (e.g., -h and -v) to a separate PR? It makes it easier to review, release, revert, debug, etc. Thanks!
There was a problem hiding this comment.
I'll try and get to that this weekend.
|
|
||
| if [[ -z "$download_url" && -n "$version" ]]; then | ||
| download_url="https://releases.hashicorp.com/consul/${version}/consul_${version}_linux_amd64.zip" | ||
| fi | ||
|
|
||
| if [[ ! -z "$addtl_headers" ]]; then | ||
| local headers |
There was a problem hiding this comment.
Move this declaration outside the if-statement.
|
|
||
| for value in "${addtl_headers[@]}" | ||
| do | ||
| headers+="-H \"$value\" " |
There was a problem hiding this comment.
Slightly cleaner to make headers an array (declare it up above local -a headers=()), appending to it here via headers+=("-H \"$value\""), and expanding it in the curl command below with ${headers[@]}.
Co-authored-by: Yevgeniy Brikman <[email protected]>
According to google arrays are always local so that bit is redundant but I like it for consistency. Co-authored-by: Yevgeniy Brikman <[email protected]>
Meant to add that, ty. Co-authored-by: Yevgeniy Brikman <[email protected]>
Co-authored-by: Yevgeniy Brikman <[email protected]>
Co-authored-by: Yevgeniy Brikman <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a --header | -H option to allow the passing of arbitrary headers.
Fixes #186