Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Run-vault submodule: add flag --data-dir #203

Merged
merged 2 commits into from
Jul 15, 2020

Conversation

andrew-womeldorf
Copy link
Contributor

As per Issue #202, the Vault data directory is not able to be set when
calling the run-vault script. It's automatically set to ../data,
relative to where the script is run.

This commit adds a flag to set the data directory.

As per Issue hashicorp#202, the Vault data directory is not able to be set when
calling the `run-vault` script. It's automatically set to `../data`,
relative to where the script is run.

This commit adds a flag to set the data directory.
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 11, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR! Just one tiny typo to fix and I can kick off tests.

modules/run-vault/run-vault Outdated Show resolved Hide resolved
Copy link
Collaborator

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll kick off tests now.

@brikis98
Copy link
Collaborator

Tests passed! Merging now.

@brikis98 brikis98 merged commit b21edc4 into hashicorp:master Jul 15, 2020
@brikis98
Copy link
Collaborator

@andrew-womeldorf
Copy link
Contributor Author

Awesome! Thank you @brikis98

@andrew-womeldorf andrew-womeldorf deleted the issue/202 branch July 15, 2020 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants