Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add support for local templates #3746

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

icholy
Copy link
Contributor

@icholy icholy commented Oct 20, 2024

Related issue

Fixes #3656

Description

Allow passing local directory as --template parameter.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@icholy icholy marked this pull request as ready for review October 20, 2024 18:43
@icholy icholy requested a review from a team as a code owner October 20, 2024 18:43
@icholy icholy requested review from ansgarm and DanielMSchmidt and removed request for a team October 20, 2024 18:43
@icholy
Copy link
Contributor Author

icholy commented Oct 20, 2024

I'm following the instructions, but I cannot get any of these integration tests to pass locally. It seems to be starting the verdaccio server, but then it errors out when trying to publish with:

npm ERR! code ENEEDAUTH
npm ERR! need auth This command requires you to be logged in to https://registry.yarnpkg.com
npm ERR! need auth You need to authorize this machine using `npm adduser`

How do I setup credentials for this local registry?

Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! Could you add the new functionality to the help text as well?

@icholy
Copy link
Contributor Author

icholy commented Oct 21, 2024

Updated.

Copy link
Contributor

Hi there! 👋 We haven't heard from you in 60 days and would like to know if you're still working on this or need help. If we don't hear from you before then, I'll auto-close this PR in 30 days.

@github-actions github-actions bot added the stale An issue or pull request that has not been updated in a very long time label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale An issue or pull request that has not been updated in a very long time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdktf-cli: support local --template files
2 participants