-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate convert and generate packages for datasource, provider, and resource #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this refactor! 😌
LGTM 🚀
@@ -1,7 +1,7 @@ | |||
// Copyright (c) HashiCorp, Inc. | |||
// SPDX-License-Identifier: MPL-2.0 | |||
|
|||
package datasource_generate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sometimes I wonder how GitHub determines it's diffs 😕 lol
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR consolidates the packages for
<datasource|provider|resource>_convert
, and<datasource|provider|resource>_generate
, intodatasource
,provider
, andresource
, respectively.The only purpose of the
<datasource|provider|resource>_convert
packages was to serve as a means to convert the types used by the Go bindings forterraform-plugin-codegen-spec
intoterraform-plugin-codegen-framework
generator types. For example:As these functions are essentially constructors for the
terraform-plugin-codegen-framework
generator types,<datasource|provider|resource>_convert
, and<datasource|provider|resource>_generate
packages have been consolidated by adding constructors, removing the<datasource|provider|resource>_convert
packages and renaming the<datasource|provider|resource>_generate
packages todatasource
,provider
, andresource
, respectively.A typical constructor looks as follows: