Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstating associate external type for primitives #55

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Oct 6, 2023

Closes: #62

This PR reinstates associated external type for bool, float64, int64, number, and string.

Related: Generate custom type and value types and to/from methods for primitives.

@bendbennett bendbennett marked this pull request as ready for review October 17, 2023 16:20
@bendbennett bendbennett requested a review from a team as a code owner October 17, 2023 16:20
spec/schema.go Outdated
@@ -9,9 +9,13 @@ import (

const (
Version0_1 = "0.1"
Version0_2 = "0.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While in the future we'll definitely want to consider publishing new minor versions, should we skip that with non-breaking enhancements for now? We could wind up with a lot of versions while we are iterating the next few months.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed re: holding off on bumping versions. Will plan to do this for codegen-framework + codegen-openapi and try to keep them in sync 👍🏻

@@ -0,0 +1,6 @@
kind: NOTES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should this be an enhancement? 😄

@bflad bflad added the enhancement New feature or request label Oct 17, 2023
@bflad bflad added this to the v0.2.0 milestone Oct 17, 2023
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bendbennett bendbennett merged commit 867ccf6 into main Oct 19, 2023
3 checks passed
@bendbennett bendbennett deleted the assoc-ext-type-primitives branch October 19, 2023 06:44
@austinvalle austinvalle modified the milestones: v0.2.0, v0.1.1 Apr 4, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Associated External Types for Primitive Attributes
3 participants