-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstating associate external type for primitives #55
Conversation
spec/schema.go
Outdated
@@ -9,9 +9,13 @@ import ( | |||
|
|||
const ( | |||
Version0_1 = "0.1" | |||
Version0_2 = "0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While in the future we'll definitely want to consider publishing new minor versions, should we skip that with non-breaking enhancements for now? We could wind up with a lot of versions while we are iterating the next few months.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed re: holding off on bumping versions. Will plan to do this for codegen-framework
+ codegen-openapi
and try to keep them in sync 👍🏻
@@ -0,0 +1,6 @@ | |||
kind: NOTES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Should this be an enhancement? 😄
10da1a1
to
264c2bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes: #62
This PR reinstates associated external type for bool, float64, int64, number, and string.
Related: Generate custom type and value types and to/from methods for primitives.