Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Add float32 type, attribute, and function support #1014

Merged
merged 23 commits into from
Jul 1, 2024
Merged

all: Add float32 type, attribute, and function support #1014

merged 23 commits into from
Jul 1, 2024

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Jun 26, 2024

Relates: #1010
This PR introduces Float32 type support to terraform-plugin-framework with the addition of:

  • Float32 type and value implementations: types.Float32Type and types.Float32
  • Custom type interfaces: basetypes.Float32Typable, basetypes.Float32Valuable and basetypes.Float32ValuableWithSemanticEquals
  • Attribute support: schema.Float32Attribute for resource, data source, and provider schemas
  • Function support: function.Float32Parameter and function.Float32Return
  • Float32 plan modifier interfaces and implementations (requires replace, use state if unknown, etc.)
  • Float32 default interfaces and static implementation
  • Float32 validation interface: validator.Float32

SBGoods and others added 19 commits June 14, 2024 19:10
@SBGoods
Add support for int32 type
766db49
@SBGoods
Add website documentation
6c3fabc
@SBGoods
Add navigation routes to website
f44a8a2
@SBGoods
Add changelog entries
295da0f
@SBGoods
Merge branch 'refs/heads/main' into SBGoods/int-float32
c325e35
@SBGoods
Initial Float32 implementation
933e305
@SBGoods @austinvalle
Fix documentation typos
7716b45 
Co-authored-by: Austin Valle <[email protected]>
@SBGoods @austinvalle
Fix casing
f2072ab 
Co-authored-by: Austin Valle <[email protected]>
@SBGoods
Add toproto5 package test
aec3ce4
@SBGoods
Remove metaschema package implementation
2661ab1
@SBGoods
Add int32 types to tables and fix typos
447cb32
@SBGoods
Add edge case testing
5c2397d
@SBGoods
Merge branch 'refs/heads/SBGoods/int-float32' into SBGoods/float32
4dbb2cb
@SBGoods
Chang NewFloat32Value implementation
56504fd
@SBGoods
Add debug logs
004c30d
@SBGoods
Fix accuracy variable shadowing
2a7e5b4
@SBGoods
Fix broken unit tests
f919104
@SBGoods
Update documentation
57c4af7
@SBGoods
Merge branch 'refs/heads/main' into SBGoods/float32
988c105 
# Conflicts:
#	tfsdk/value_as_test.go
#	website/docs/plugin/framework/functions/returns/index.mdx
@SBGoods SBGoods requested a review from a team as a code owner June 26, 2024 16:29
@SBGoods SBGoods added this to the v1.10.0 milestone Jun 26, 2024
@SBGoods SBGoods added the enhancement New feature or request label Jun 26, 2024
This was referenced Jun 26, 2024
Merged
Merged
austinvalle
austinvalle approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Everything lgtm, just had two notes to consider but nothing blocking 🚀

internal/fwserver/server_planresourcechange_test.go Show resolved Hide resolved
types/basetypes/float32_type.go Outdated Show resolved Hide resolved
@SBGoods SBGoods merged commit 758afb7 into main Jul 1, 2024
31 checks passed
@SBGoods SBGoods deleted the SBGoods/float32 branch July 1, 2024 16:56
@SBGoods SBGoods mentioned this pull request Jul 1, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@austinvalle austinvalle austinvalle approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SBGoods @austinvalle