ListResource: revisit handling of null ListResult fields
#1167
+123
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbasata
force-pushed
the
listresource-tidy
branch
from
91cfa76 to
6075e3f
Compare
bbasata
force-pushed
the
listresource-tidy
branch
from
6075e3f to
7dce0b7
Compare
bbasata
changed the title
ListResult fields
bbasata
force-pushed
the
listresource-tidy
branch
from
62c8251 to
65651f6
Compare
1 task
austinvalle
approved these changes
Jun 24, 2025
| @@ -103,6 +103,18 @@ type ListRequest struct { | |||
| ResourceIdentitySchema fwschema.Schema | |||
| } | |||
|
|
|||
| func (r ListRequest) NewListResult() ListResult { | |||
There was a problem hiding this comment.
nit: Eventually should add a package doc here explaining when it should be used (i.e. always really 😅 )
| Diagnostics: diag.Diagnostics{}, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Future consideration: Should we eventually add a NewListResultsWithDiag so that you always create results from the request struct? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ListResult.{Identity,Resource}can be "null" in a couple ways. This change handles both.It also updates diagnostic messages to be more user-actionable.
Rollback Plan
Changes to Security Controls
None