Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knownvalue: Add TupleExact, TuplePartial and TupleSizeExact checks for dynamic value testing #313

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

austinvalle
Copy link
Member

Closes #312

Exact copies of the List* equivalents.

Notes

I explicitly didn't add documentation, since these are only really useful for dynamic value testing, but I can add them if we think it's necessary 👍🏻

@austinvalle austinvalle added the enhancement New feature or request label Mar 25, 2024
@austinvalle austinvalle requested a review from a team as a code owner March 25, 2024 16:07
@austinvalle austinvalle changed the title knownvalue: Add TupleExact, TuplePartial and TupleSizeExact checks for dynamic value testing. knownvalue: Add TupleExact, TuplePartial and TupleSizeExact checks for dynamic value testing Mar 25, 2024
@austinvalle austinvalle added this to the v1.8.0 milestone Mar 25, 2024
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

I think it might be worth the additional tuple documentation page, even if it is copy-paste-modify of the list page for now (maybe with a small callout that tuples are relatively uncommon except for testing dynamic types).

@austinvalle
Copy link
Member Author

I think it might be worth the additional tuple documentation page, even if it is copy-paste-modify of the list page for now (maybe with a small callout that tuples are relatively uncommon except for testing dynamic types).

Added in 29d51b5 ⚡ - I adjusted the wording as well as added a little blurb mentioning they are only encountered when testing dynamic data 🚀

@austinvalle austinvalle merged commit c294752 into main Mar 25, 2024
29 checks passed
@austinvalle austinvalle deleted the av/tuple-knownvalue branch March 25, 2024 22:01
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding Tuple* known value checks
2 participants