361: Don't return filepath.SkipDir from the WalkFunc when excluding symlinked directories…

[metmikel]

…, as the item at the path being processed is a symlink and according to https://pkg.go.dev/path/filepath#WalkFunc, returning filepath.SkipDir from WalkFunc when the item being processed is not a directory will skip the parent directory - which is not the desired behavior.

[hashicorp-cla-app]

All committers have signed the CLA.

[SBGoods]

Hi @metmikel 👋🏾,
Thank you for submitting this PR. The change and rationale here makes sense to me. Before approving this PR, though, is it possible to add a unit test case in zip_archiver_test.go and acceptance test cases in resource_archive_file_zip_test.go and data_source_archive_file_zip_test.go?

Also it looks like this issue also affects tar_achiver.go, so if you would like to make corresponding changes/tests for the tar archiver that would be appreciated! If not, no worries, I'll open up a follow up PR after merging this one.

Thanks!

[metmikel]

Hi @SBGoods,
Apologies for the long delay replying. I was hoping to make the changes you suggested, but I have to confess that this is the first time I have done anything in Go and while I was hoping to do some learning in that area, work commitments have got in the way. Hopefully somebody else who is impacted by this issue will be able to pick it up.

[jiw-mh]

@metmikel
Does this also need to be added to the tar archiver?

[metmikel]

@metmikel Does this also need to be added to the tar archiver?

@jiw-mh Yes, agreed, it seems to follow the same pattern there. (There is also a redundant check at line 144 - err is checked prior to that at line 129).