Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-retry limit support for CodeBuild #40035

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rayennh
Copy link

@rayennh rayennh commented Nov 7, 2024

Description

This pull request adds the auto_retry_limit argument to the aws_codebuild_project resource. This new setting allows users to specify the number of automatic retry attempts for a CodeBuild project.

Relations

Closes #39921

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccCodeBuildProject_autoRetryLimit PKG=codebuild

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildProject_autoRetryLimit'  -timeout 360m
2024/11/08 13:44:56 Initializing Terraform AWS Provider...
=== RUN   TestAccCodeBuildProject_autoRetryLimit
=== PAUSE TestAccCodeBuildProject_autoRetryLimit
=== CONT  TestAccCodeBuildProject_autoRetryLimit
--- PASS: TestAccCodeBuildProject_autoRetryLimit (51.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codebuild  55.902s

Copy link

github-actions bot commented Nov 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codebuild Issues and PRs that pertain to the codebuild service. needs-triage Waiting for first response or review from a maintainer. labels Nov 7, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @rayennh 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@rayennh rayennh force-pushed the f-code_build-auto_retry_limit branch from 901281c to 39ab00b Compare November 8, 2024 12:49
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 8, 2024
@rayennh rayennh marked this pull request as ready for review November 8, 2024 17:17
@rayennh rayennh requested a review from a team as a code owner November 8, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for CodeBuild auto-retry
2 participants