Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws_bedrock_knowledge_base_logging_configuration resource #40070

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

theolrvlv
Copy link

@theolrvlv theolrvlv commented Nov 9, 2024

Description

Implement a new Terraform resource aws_bedrock_knowledge_base_logging_configuration to manage logging configurations for individual Amazon Bedrock Knowledge Bases. This resource allows users to configure logging settings for specific knowledge bases, including specifying the destination for log data (e.g., Amazon S3, Amazon CloudWatch) and ingestes jobs data to include in the logs.

This resource is similar to aws_bedrock_model_invocation_logging_configuration but is scoped to individual knowledge bases and can be imported by knowledge base ID.

Relations

Closes #40027

References

AWS bedrock kb logs
Example of logs

AWS vented logs

Can be inspired by existing terraform resource :
aws_bedrock_model_invocation_logging_configuration

Output from Acceptance Testing

TO BE TESTED

@theolrvlv theolrvlv requested a review from a team as a code owner November 9, 2024 14:20
Copy link

github-actions bot commented Nov 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/bedrock Issues and PRs that pertain to the bedrock service. needs-triage Waiting for first response or review from a maintainer. labels Nov 9, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @theolrvlv 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added the generators Relates to code generators. label Nov 9, 2024
@theolrvlv theolrvlv marked this pull request as draft November 10, 2024 14:19
@jar-b jar-b added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generators Relates to code generators. new-resource Introduces a new resource. service/bedrock Issues and PRs that pertain to the bedrock service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_bedrock_knowledge_base_logging_configuration
2 participants