Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eks_node_group.html.markdown to AL2023 #40099

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ilyesAj
Copy link

@ilyesAj ilyesAj commented Nov 12, 2024

Original Sentences

You can have the node group track the latest version of the Amazon EKS optimized Amazon Linux AMI for a given EKS version by querying an Amazon provided SSM parameter. Replace amazon-linux-2 in the parameter name below with amazon-linux-2-gpu to retrieve the accelerated AMI version and amazon-linux-2-arm64 to retrieve the Arm version.

Issues in the Original Sentences

Outdated. Starting from EKS 1.30, amazon linux 2023 is used instead of amazon-linux-2 and the terraform provider uses by default amazon linux 2023

Final Sentences

You can have the node group track the latest version of the Amazon EKS optimized Amazon Linux AMI for a given EKS version by querying an Amazon provided SSM parameter. Replace standard in the parameter name below with nvidia to retrieve the accelerated AMI version.
Replace x86_64in the parameter name below with arm64 to retrieve the Arm version.

Conclusion

Aligning the documentation with the latest releases of terraform provider avoids confusion and prevents users to loose time to search the data needed.

Closes #0000

References

@ilyesAj ilyesAj requested a review from a team as a code owner November 12, 2024 18:27
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. needs-triage Waiting for first response or review from a maintainer. labels Nov 12, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ilyesAj 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant