Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in Evidently sweepers #40105

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix panic in Evidently sweepers #40105

merged 1 commit into from
Nov 13, 2024
+24 −50

Conversation

gdavison
Copy link
Contributor

Description

Evidently sweepers were failing with a panic due to the error

api error NoLongerSupportedException: AWS Evidently has been discontinued.

@gdavison gdavison requested a review from a team as a code owner November 12, 2024 22:57
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. service/evidently Issues and PRs that pertain to the evidently service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 12, 2024
jar-b
jar-b approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gdavison gdavison merged commit 17cd7ee into main Nov 13, 2024
38 checks passed
@gdavison gdavison deleted the b-sweep-evidently branch November 13, 2024 19:41
@github-actions github-actions bot added this to the v5.76.0 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/evidently Issues and PRs that pertain to the evidently service. sweeper Pertains to changes to or issues with the sweeper.
Projects
None yet
Milestone
v5.76.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @jar-b