add override_provider block to s3 object copy #40689
Merged
+298
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @jafournier 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
jafournier
changed the title
ewbankkit
added
enhancement
ewbankkit
previously approved these changes
Jan 6, 2025
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccS3ObjectCopy_' PKG=s3 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/s3/... -v -count 1 -parallel 3 -run=TestAccS3ObjectCopy_ -timeout 360m
2025/01/06 14:35:32 Initializing Terraform AWS Provider...
=== RUN TestAccS3ObjectCopy_tags
=== PAUSE TestAccS3ObjectCopy_tags
=== RUN TestAccS3ObjectCopy_tags_null
=== PAUSE TestAccS3ObjectCopy_tags_null
=== RUN TestAccS3ObjectCopy_tags_EmptyMap
=== PAUSE TestAccS3ObjectCopy_tags_EmptyMap
=== RUN TestAccS3ObjectCopy_tags_AddOnUpdate
=== PAUSE TestAccS3ObjectCopy_tags_AddOnUpdate
=== RUN TestAccS3ObjectCopy_tags_EmptyTag_OnCreate
=== PAUSE TestAccS3ObjectCopy_tags_EmptyTag_OnCreate
=== RUN TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Add
=== RUN TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Replace
=== RUN TestAccS3ObjectCopy_tags_DefaultTags_providerOnly
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_providerOnly
=== RUN TestAccS3ObjectCopy_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_nonOverlapping
=== RUN TestAccS3ObjectCopy_tags_DefaultTags_overlapping
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_overlapping
=== RUN TestAccS3ObjectCopy_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_updateToProviderOnly
=== RUN TestAccS3ObjectCopy_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_updateToResourceOnly
=== RUN TestAccS3ObjectCopy_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_emptyResourceTag
=== RUN TestAccS3ObjectCopy_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_emptyProviderOnlyTag
=== RUN TestAccS3ObjectCopy_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_nullOverlappingResourceTag
=== RUN TestAccS3ObjectCopy_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccS3ObjectCopy_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN TestAccS3ObjectCopy_tags_ComputedTag_OnCreate
=== PAUSE TestAccS3ObjectCopy_tags_ComputedTag_OnCreate
=== RUN TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Add
=== RUN TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Replace
=== RUN TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_DefaultTag
=== RUN TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_ResourceTag
=== RUN TestAccS3ObjectCopy_basic
=== PAUSE TestAccS3ObjectCopy_basic
=== RUN TestAccS3ObjectCopy_disappears
=== PAUSE TestAccS3ObjectCopy_disappears
=== RUN TestAccS3ObjectCopy_metadata
=== PAUSE TestAccS3ObjectCopy_metadata
=== RUN TestAccS3ObjectCopy_grant
=== PAUSE TestAccS3ObjectCopy_grant
=== RUN TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== RUN TestAccS3ObjectCopy_BucketKeyEnabled_object
=== PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_object
=== RUN TestAccS3ObjectCopy_DefaultTags_providerOnly
=== PAUSE TestAccS3ObjectCopy_DefaultTags_providerOnly
=== RUN TestAccS3ObjectCopy_DefaultTags_providerAndResource
=== PAUSE TestAccS3ObjectCopy_DefaultTags_providerAndResource
=== RUN TestAccS3ObjectCopy_DefaultTags_providerAndResourceWithOverride
=== PAUSE TestAccS3ObjectCopy_DefaultTags_providerAndResourceWithOverride
=== RUN TestAccS3ObjectCopy_sourceWithSlashes
=== PAUSE TestAccS3ObjectCopy_sourceWithSlashes
=== RUN TestAccS3ObjectCopy_checksumAlgorithm
=== PAUSE TestAccS3ObjectCopy_checksumAlgorithm
=== RUN TestAccS3ObjectCopy_objectLockLegalHold
=== PAUSE TestAccS3ObjectCopy_objectLockLegalHold
=== RUN TestAccS3ObjectCopy_targetWithMultipleSlashes
=== PAUSE TestAccS3ObjectCopy_targetWithMultipleSlashes
=== RUN TestAccS3ObjectCopy_targetWithMultipleSlashesMigrated
=== PAUSE TestAccS3ObjectCopy_targetWithMultipleSlashesMigrated
=== RUN TestAccS3ObjectCopy_directoryBucket
=== PAUSE TestAccS3ObjectCopy_directoryBucket
=== RUN TestAccS3ObjectCopy_basicViaAccessPoint
=== PAUSE TestAccS3ObjectCopy_basicViaAccessPoint
=== CONT TestAccS3ObjectCopy_tags
=== CONT TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_DefaultTag
=== CONT TestAccS3ObjectCopy_DefaultTags_providerAndResource
--- PASS: TestAccS3ObjectCopy_DefaultTags_providerAndResource (23.29s)
=== CONT TestAccS3ObjectCopy_basicViaAccessPoint
--- PASS: TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_DefaultTag (39.91s)
=== CONT TestAccS3ObjectCopy_directoryBucket
--- PASS: TestAccS3ObjectCopy_basicViaAccessPoint (19.98s)
=== CONT TestAccS3ObjectCopy_targetWithMultipleSlashesMigrated
--- PASS: TestAccS3ObjectCopy_tags (53.36s)
=== CONT TestAccS3ObjectCopy_targetWithMultipleSlashes
--- PASS: TestAccS3ObjectCopy_directoryBucket (17.46s)
=== CONT TestAccS3ObjectCopy_objectLockLegalHold
--- PASS: TestAccS3ObjectCopy_targetWithMultipleSlashes (14.37s)
=== CONT TestAccS3ObjectCopy_checksumAlgorithm
--- PASS: TestAccS3ObjectCopy_targetWithMultipleSlashesMigrated (45.32s)
=== CONT TestAccS3ObjectCopy_sourceWithSlashes
--- PASS: TestAccS3ObjectCopy_objectLockLegalHold (31.72s)
=== CONT TestAccS3ObjectCopy_DefaultTags_providerAndResourceWithOverride
--- PASS: TestAccS3ObjectCopy_checksumAlgorithm (25.81s)
=== CONT TestAccS3ObjectCopy_grant
--- PASS: TestAccS3ObjectCopy_grant (16.05s)
=== CONT TestAccS3ObjectCopy_DefaultTags_providerOnly
--- PASS: TestAccS3ObjectCopy_DefaultTags_providerAndResourceWithOverride (23.65s)
=== CONT TestAccS3ObjectCopy_BucketKeyEnabled_object
--- PASS: TestAccS3ObjectCopy_sourceWithSlashes (25.62s)
=== CONT TestAccS3ObjectCopy_BucketKeyEnabled_bucket
--- PASS: TestAccS3ObjectCopy_DefaultTags_providerOnly (13.50s)
=== CONT TestAccS3ObjectCopy_disappears
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_object (14.99s)
=== CONT TestAccS3ObjectCopy_metadata
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_bucket (15.57s)
=== CONT TestAccS3ObjectCopy_basic
--- PASS: TestAccS3ObjectCopy_disappears (15.42s)
=== CONT TestAccS3ObjectCopy_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccS3ObjectCopy_metadata (15.11s)
=== CONT TestAccS3ObjectCopy_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccS3ObjectCopy_basic (14.88s)
=== CONT TestAccS3ObjectCopy_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_nullNonOverlappingResourceTag (16.33s)
=== CONT TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_nullOverlappingResourceTag (16.23s)
=== CONT TestAccS3ObjectCopy_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_updateToProviderOnly (30.06s)
=== CONT TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_emptyProviderOnlyTag (16.25s)
=== CONT TestAccS3ObjectCopy_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Replace (29.19s)
=== CONT TestAccS3ObjectCopy_tags_ComputedTag_OnCreate
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_emptyResourceTag (16.83s)
=== CONT TestAccS3ObjectCopy_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccS3ObjectCopy_tags_ComputedTag_OnUpdate_Add (29.64s)
=== CONT TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccS3ObjectCopy_tags_ComputedTag_OnCreate (17.91s)
=== CONT TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_updateToResourceOnly (30.57s)
=== CONT TestAccS3ObjectCopy_tags_DefaultTags_nonOverlapping
--- PASS: TestAccS3ObjectCopy_tags_IgnoreTags_Overlap_ResourceTag (43.99s)
=== CONT TestAccS3ObjectCopy_tags_DefaultTags_providerOnly
--- PASS: TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Add (40.07s)
=== CONT TestAccS3ObjectCopy_tags_DefaultTags_overlapping
=== CONT TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_nonOverlapping (45.48s)
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_overlapping (45.62s)
=== CONT TestAccS3ObjectCopy_tags_AddOnUpdate
--- PASS: TestAccS3ObjectCopy_tags_EmptyTag_OnUpdate_Replace (28.29s)
=== CONT TestAccS3ObjectCopy_tags_EmptyTag_OnCreate
--- PASS: TestAccS3ObjectCopy_tags_DefaultTags_providerOnly (59.87s)
=== CONT TestAccS3ObjectCopy_tags_EmptyMap
--- PASS: TestAccS3ObjectCopy_tags_AddOnUpdate (28.09s)
=== CONT TestAccS3ObjectCopy_tags_null
--- PASS: TestAccS3ObjectCopy_tags_EmptyMap (20.94s)
--- PASS: TestAccS3ObjectCopy_tags_EmptyTag_OnCreate (27.85s)
--- PASS: TestAccS3ObjectCopy_tags_null (21.59s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 347.392s
jar-b
reviewed
Jan 6, 2025
Co-authored-by: Jared Baker <[email protected]>
Co-authored-by: Jared Baker <[email protected]>
|
@jafournier Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The override_provider block has already been introduced on aws_s3_object resource to allow ingoring provider default tags here.
This MR introduces this same option to the aws_s3_object_copy resource.
This option allows users to ignore default tags set at the provider level when managing S3 object copy resources.
Organizations that utilize a large number of default tags can encounter limitations when working with S3 objects due to the maximum tag limit (currently 10). This change enables users to more easily work with S3 objects in such environments by providing the option to ignore default tags, thus avoiding the need for aliasing providers to mitigate the tag limitation.
Relations
Relates #19895.
Relates #21273.
Relates #33262.
Output from Acceptance Testing