[Enhancement] Add `resource_configuration_arn` and `service_network_arn` to `vpc_endpoint` #41116

drewtul · 2025-01-28T10:41:42Z

Description

Add resource_configuration_arn and service_network_arn to vpc_endpoint

Note there's some case differences in the values of State returned from the API depending on the type of the VPC Endpoint. This PR normalises the comparisons of state to lowercase against the constants in consts.go and does not use the State enum from the SDK.

Relations

Relates #40384

References

Output from Acceptance Testing

%  make testacc ACCTEST_PARALLELISM=3 TESTS=TestAccVPCEndpoint_ PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCEndpoint_'  -timeout 360m -vet=off
2025/01/28 20:47:02 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCEndpoint_gatewayBasic
=== PAUSE TestAccVPCEndpoint_gatewayBasic
=== RUN   TestAccVPCEndpoint_interfaceBasic
=== PAUSE TestAccVPCEndpoint_interfaceBasic
=== RUN   TestAccVPCEndpoint_interfaceNoPrivateDNS
=== PAUSE TestAccVPCEndpoint_interfaceNoPrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNS
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== RUN   TestAccVPCEndpoint_disappears
=== PAUSE TestAccVPCEndpoint_disappears
=== RUN   TestAccVPCEndpoint_tags
=== PAUSE TestAccVPCEndpoint_tags
=== RUN   TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccVPCEndpoint_gatewayPolicy
=== PAUSE TestAccVPCEndpoint_gatewayPolicy
=== RUN   TestAccVPCEndpoint_ignoreEquivalent
=== PAUSE TestAccVPCEndpoint_ignoreEquivalent
=== RUN   TestAccVPCEndpoint_ipAddressType
=== PAUSE TestAccVPCEndpoint_ipAddressType
=== RUN   TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccVPCEndpoint_interfaceUserDefinedIPv4
=== PAUSE TestAccVPCEndpoint_interfaceUserDefinedIPv4
=== RUN   TestAccVPCEndpoint_interfaceUserDefinedIPv6
=== PAUSE TestAccVPCEndpoint_interfaceUserDefinedIPv6
=== RUN   TestAccVPCEndpoint_interfaceUserDefinedDualstack
=== PAUSE TestAccVPCEndpoint_interfaceUserDefinedDualstack
=== RUN   TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== PAUSE TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== RUN   TestAccVPCEndpoint_crossRegionService
=== PAUSE TestAccVPCEndpoint_crossRegionService
=== RUN   TestAccVPCEndpoint_invalidCrossRegionService
=== PAUSE TestAccVPCEndpoint_invalidCrossRegionService
=== RUN   TestAccVPCEndpoint_resourceConfiguration
=== PAUSE TestAccVPCEndpoint_resourceConfiguration
=== RUN   TestAccVPCEndpoint_serviceNetwork
=== PAUSE TestAccVPCEndpoint_serviceNetwork
=== CONT  TestAccVPCEndpoint_gatewayBasic
=== CONT  TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== CONT  TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
--- PASS: TestAccVPCEndpoint_gatewayBasic (38.92s)
=== CONT  TestAccVPCEndpoint_interfaceUserDefinedIPv4
--- PASS: TestAccVPCEndpoint_interfaceUserDefinedIPv4 (191.53s)
=== CONT  TestAccVPCEndpoint_interfaceUserDefinedDualstack
--- PASS: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (331.38s)
=== CONT  TestAccVPCEndpoint_interfaceUserDefinedIPv6
--- PASS: TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer (384.73s)
=== CONT  TestAccVPCEndpoint_tags
--- PASS: TestAccVPCEndpoint_tags (69.78s)
=== CONT  TestAccVPCEndpoint_ipAddressType
--- PASS: TestAccVPCEndpoint_interfaceUserDefinedDualstack (246.29s)
=== CONT  TestAccVPCEndpoint_ignoreEquivalent
--- PASS: TestAccVPCEndpoint_interfaceUserDefinedIPv6 (181.32s)
=== CONT  TestAccVPCEndpoint_gatewayPolicy
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (44.56s)
=== CONT  TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccVPCEndpoint_gatewayPolicy (62.51s)
=== CONT  TestAccVPCEndpoint_resourceConfiguration
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (63.01s)
=== CONT  TestAccVPCEndpoint_serviceNetwork
--- PASS: TestAccVPCEndpoint_serviceNetwork (82.30s)
=== CONT  TestAccVPCEndpoint_interfacePrivateDNS
--- PASS: TestAccVPCEndpoint_resourceConfiguration (118.00s)
=== CONT  TestAccVPCEndpoint_disappears
--- PASS: TestAccVPCEndpoint_disappears (33.12s)
=== CONT  TestAccVPCEndpoint_interfacePrivateDNSNoGateway
--- PASS: TestAccVPCEndpoint_ipAddressType (366.48s)
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccVPCEndpoint_interfacePrivateDNS (516.41s)
=== CONT  TestAccVPCEndpoint_interfaceNoPrivateDNS
--- PASS: TestAccVPCEndpoint_interfacePrivateDNSNoGateway (465.05s)
=== CONT  TestAccVPCEndpoint_interfaceBasic
--- PASS: TestAccVPCEndpoint_interfaceNoPrivateDNS (44.95s)
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (424.46s)
=== CONT  TestAccVPCEndpoint_invalidCrossRegionService
--- PASS: TestAccVPCEndpoint_interfaceBasic (65.56s)
=== CONT  TestAccVPCEndpoint_crossRegionService
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (244.29s)
--- PASS: TestAccVPCEndpoint_invalidCrossRegionService (258.92s)
--- PASS: TestAccVPCEndpoint_crossRegionService (460.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1722.051s

%  make testacc ACCTEST_PARALLELISM=3 TESTS=TestAccVPCEndpointPolicy_ PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCEndpointPolicy_'  -timeout 360m -vet=off
2025/01/28 21:33:03 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCEndpointPolicy_basic
=== PAUSE TestAccVPCEndpointPolicy_basic
=== RUN   TestAccVPCEndpointPolicy_disappears
=== PAUSE TestAccVPCEndpointPolicy_disappears
=== RUN   TestAccVPCEndpointPolicy_disappears_endpoint
=== PAUSE TestAccVPCEndpointPolicy_disappears_endpoint
=== CONT  TestAccVPCEndpointPolicy_basic
=== CONT  TestAccVPCEndpointPolicy_disappears_endpoint
=== CONT  TestAccVPCEndpointPolicy_disappears
--- PASS: TestAccVPCEndpointPolicy_disappears_endpoint (41.60s)
--- PASS: TestAccVPCEndpointPolicy_disappears (52.87s)
--- PASS: TestAccVPCEndpointPolicy_basic (72.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        77.143s

% make testacc ACCTEST_PARALLELISM=3 TESTS=TestAccVPCEndpointConnectionAccepter_ PKG=ec2 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCEndpointConnectionAccepter_'  -timeout 360m -vet=off
2025/01/28 21:38:07 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCEndpointConnectionAccepter_crossAccount
--- PASS: TestAccVPCEndpointConnectionAccepter_crossAccount (363.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        369.806s

%  make testacc ACCTEST_PARALLELISM=3 TESTS=TestAccVPCEndpointSubnetAssociation_ PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccVPCEndpointSubnetAssociation_'  -timeout 360m -vet=off
2025/01/28 21:45:40 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCEndpointSubnetAssociation_basic
=== PAUSE TestAccVPCEndpointSubnetAssociation_basic
=== RUN   TestAccVPCEndpointSubnetAssociation_disappears
=== PAUSE TestAccVPCEndpointSubnetAssociation_disappears
=== RUN   TestAccVPCEndpointSubnetAssociation_multiple
=== PAUSE TestAccVPCEndpointSubnetAssociation_multiple
=== CONT  TestAccVPCEndpointSubnetAssociation_basic
=== CONT  TestAccVPCEndpointSubnetAssociation_multiple
=== CONT  TestAccVPCEndpointSubnetAssociation_disappears
--- PASS: TestAccVPCEndpointSubnetAssociation_basic (226.56s)
--- PASS: TestAccVPCEndpointSubnetAssociation_disappears (243.28s)
--- PASS: TestAccVPCEndpointSubnetAssociation_multiple (462.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        466.985s

github-actions · 2025-01-28T10:41:57Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

website/docs/r/vpc_endpoint.html.markdown

…re getting mixed case values, this gets Resource type endpoints working

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCEndpoint_\|TestAccVPCEndpointPolicy_\|TestAccVPCEndpointSubnetAssociation_' PKG=ec2 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccVPCEndpoint_\|TestAccVPCEndpointPolicy_\|TestAccVPCEndpointSubnetAssociation_ -timeout 360m -vet=off
2025/01/28 17:48:03 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCEndpointPolicy_basic
=== PAUSE TestAccVPCEndpointPolicy_basic
=== RUN   TestAccVPCEndpointPolicy_disappears
=== PAUSE TestAccVPCEndpointPolicy_disappears
=== RUN   TestAccVPCEndpointPolicy_disappears_endpoint
=== PAUSE TestAccVPCEndpointPolicy_disappears_endpoint
=== RUN   TestAccVPCEndpointSubnetAssociation_basic
=== PAUSE TestAccVPCEndpointSubnetAssociation_basic
=== RUN   TestAccVPCEndpointSubnetAssociation_disappears
=== PAUSE TestAccVPCEndpointSubnetAssociation_disappears
=== RUN   TestAccVPCEndpointSubnetAssociation_multiple
=== PAUSE TestAccVPCEndpointSubnetAssociation_multiple
=== RUN   TestAccVPCEndpoint_gatewayBasic
=== PAUSE TestAccVPCEndpoint_gatewayBasic
=== RUN   TestAccVPCEndpoint_interfaceBasic
=== PAUSE TestAccVPCEndpoint_interfaceBasic
=== RUN   TestAccVPCEndpoint_interfaceNoPrivateDNS
=== PAUSE TestAccVPCEndpoint_interfaceNoPrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNS
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNS
=== RUN   TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== PAUSE TestAccVPCEndpoint_interfacePrivateDNSNoGateway
=== RUN   TestAccVPCEndpoint_disappears
=== PAUSE TestAccVPCEndpoint_disappears
=== RUN   TestAccVPCEndpoint_tags
=== PAUSE TestAccVPCEndpoint_tags
=== RUN   TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccVPCEndpoint_gatewayPolicy
=== PAUSE TestAccVPCEndpoint_gatewayPolicy
=== RUN   TestAccVPCEndpoint_ignoreEquivalent
=== PAUSE TestAccVPCEndpoint_ignoreEquivalent
=== RUN   TestAccVPCEndpoint_ipAddressType
=== PAUSE TestAccVPCEndpoint_ipAddressType
=== RUN   TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccVPCEndpoint_interfaceUserDefinedIPv4
=== PAUSE TestAccVPCEndpoint_interfaceUserDefinedIPv4
=== RUN   TestAccVPCEndpoint_interfaceUserDefinedIPv6
=== PAUSE TestAccVPCEndpoint_interfaceUserDefinedIPv6
=== RUN   TestAccVPCEndpoint_interfaceUserDefinedDualstack
=== PAUSE TestAccVPCEndpoint_interfaceUserDefinedDualstack
=== RUN   TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== PAUSE TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== RUN   TestAccVPCEndpoint_crossRegionService
=== PAUSE TestAccVPCEndpoint_crossRegionService
=== RUN   TestAccVPCEndpoint_invalidCrossRegionService
=== PAUSE TestAccVPCEndpoint_invalidCrossRegionService
=== RUN   TestAccVPCEndpoint_resourceConfiguration
=== PAUSE TestAccVPCEndpoint_resourceConfiguration
=== RUN   TestAccVPCEndpoint_serviceNetwork
=== PAUSE TestAccVPCEndpoint_serviceNetwork
=== CONT  TestAccVPCEndpointPolicy_basic
=== CONT  TestAccVPCEndpoint_gatewayPolicy
=== CONT  TestAccVPCEndpoint_interfaceBasic
=== CONT  TestAccVPCEndpoint_interfacePrivateDNSNoGateway
--- PASS: TestAccVPCEndpoint_gatewayPolicy (48.08s)
=== CONT  TestAccVPCEndpoint_disappears
--- PASS: TestAccVPCEndpointPolicy_basic (58.67s)
=== CONT  TestAccVPCEndpoint_interfacePrivateDNS
--- PASS: TestAccVPCEndpoint_disappears (26.68s)
=== CONT  TestAccVPCEndpoint_interfaceNoPrivateDNS
--- PASS: TestAccVPCEndpoint_interfaceBasic (80.02s)
=== CONT  TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (46.54s)
=== CONT  TestAccVPCEndpoint_tags
--- PASS: TestAccVPCEndpoint_interfaceNoPrivateDNS (74.14s)
=== CONT  TestAccVPCEndpoint_interfaceUserDefinedIPv6
--- PASS: TestAccVPCEndpoint_tags (52.20s)
=== CONT  TestAccVPCEndpoint_serviceNetwork
--- PASS: TestAccVPCEndpoint_serviceNetwork (64.16s)
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccVPCEndpoint_interfaceUserDefinedIPv6 (194.14s)
=== CONT  TestAccVPCEndpoint_resourceConfiguration
--- PASS: TestAccVPCEndpoint_interfacePrivateDNSNoGateway (446.26s)
=== CONT  TestAccVPCEndpoint_invalidCrossRegionService
--- PASS: TestAccVPCEndpoint_resourceConfiguration (114.99s)
=== CONT  TestAccVPCEndpoint_interfaceUserDefinedIPv4
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (258.75s)
=== CONT  TestAccVPCEndpoint_crossRegionService
=== CONT  TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccVPCEndpoint_interfacePrivateDNS (532.64s)
--- PASS: TestAccVPCEndpoint_interfaceUserDefinedIPv4 (217.26s)
=== CONT  TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
--- PASS: TestAccVPCEndpoint_invalidCrossRegionService (231.59s)
=== CONT  TestAccVPCEndpointSubnetAssociation_disappears
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (274.33s)
=== CONT  TestAccVPCEndpoint_interfaceUserDefinedDualstack
--- PASS: TestAccVPCEndpointSubnetAssociation_disappears (228.03s)
=== CONT  TestAccVPCEndpoint_gatewayBasic
--- PASS: TestAccVPCEndpoint_gatewayBasic (28.62s)
=== CONT  TestAccVPCEndpoint_ipAddressType
--- PASS: TestAccVPCEndpoint_crossRegionService (478.83s)
=== CONT  TestAccVPCEndpointSubnetAssociation_multiple
--- PASS: TestAccVPCEndpoint_interfaceUserDefinedDualstack (193.11s)
=== CONT  TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer (391.54s)
=== CONT  TestAccVPCEndpointPolicy_disappears
--- PASS: TestAccVPCEndpointPolicy_disappears (44.45s)
=== CONT  TestAccVPCEndpointPolicy_disappears_endpoint
--- PASS: TestAccVPCEndpointPolicy_disappears_endpoint (33.24s)
=== CONT  TestAccVPCEndpointSubnetAssociation_basic
--- PASS: TestAccVPCEndpoint_ipAddressType (286.87s)
=== CONT  TestAccVPCEndpoint_ignoreEquivalent
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (32.09s)
--- PASS: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (244.29s)
--- PASS: TestAccVPCEndpointSubnetAssociation_basic (204.84s)
--- PASS: TestAccVPCEndpointSubnetAssociation_multiple (390.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1377.090s

…faceBasic'.

% make testacc TESTARGS='-run=TestAccVPCEndpoint_gatewayBasic\|TestAccVPCEndpoint_interfaceBasic' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCEndpoint_gatewayBasic\|TestAccVPCEndpoint_interfaceBasic -timeout 360m -vet=off 2025/01/29 07:44:31 Initializing Terraform AWS Provider... === RUN TestAccVPCEndpoint_gatewayBasic === PAUSE TestAccVPCEndpoint_gatewayBasic === RUN TestAccVPCEndpoint_interfaceBasic === PAUSE TestAccVPCEndpoint_interfaceBasic === CONT TestAccVPCEndpoint_gatewayBasic === CONT TestAccVPCEndpoint_interfaceBasic --- PASS: TestAccVPCEndpoint_gatewayBasic (34.97s) --- PASS: TestAccVPCEndpoint_interfaceBasic (54.68s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 60.448s

ewbankkit · 2025-01-29T13:08:42Z

% make testacc-tflint
Installing "aws" plugin...
Installed "aws" (source: github.com/terraform-linters/tflint-ruleset-aws, version: 0.37.0)
make: Acceptance Test Linting (standalone) / tflint...
make: Acceptance Test Linting (embedded) / tflint...

…nvalid_certificate' has been removed.

ewbankkit · 2025-01-29T15:46:57Z

@drewtul Thanks for the contribution 🎉 👏.

drewtul added 2 commits January 28, 2025 10:32

add resource and service network arn properties

9abb933

Docs

0dc95cf

github-actions bot added documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jan 28, 2025

ewbankkit reviewed Jan 28, 2025

View reviewed changes

website/docs/r/vpc_endpoint.html.markdown Show resolved Hide resolved

Doc additional type values

d907e07

justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 28, 2025

Normalise checking of the state of an endpoint to lowercase since we'…

90df6af

…re getting mixed case values, this gets Resource type endpoints working

github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. labels Jan 28, 2025

drewtul added 3 commits January 28, 2025 20:47

Add test for ServiceNetwork type

077dfb4

changelog

341dd7e

Sort examples of Resource and ServiceNetwork endpoint types

3bb0dbf

drewtul marked this pull request as ready for review January 28, 2025 21:55

drewtul requested a review from a team as a code owner January 28, 2025 21:55

ewbankkit self-assigned this Jan 28, 2025

github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 28, 2025

ewbankkit added 3 commits January 28, 2025 17:29

Tweak CHANGELOG entry.

e482cff

Cosmetics.

df8e5cc

Use latest (v0.37.0) version of 'tflint-ruleset-aws'.

ff8643a

ewbankkit previously approved these changes Jan 28, 2025

View reviewed changes

tflint: Remove 'aws_glue_connection_invalid_connection_type' rule.

af5739d

ewbankkit dismissed their stale review via af5739d January 28, 2025 23:24

ewbankkit added 3 commits January 29, 2025 07:42

Fix semgrep 'ci.helper-schema-ResourceData-Set-extraneous-nil-check'.

8d2a877

Tweak 'TestAccVPCEndpoint_gatewayBasic' and 'TestAccVPCEndpoint_inter…

6291803

…faceBasic'.

tflint rule 'aws_worklink_website_certificate_authority_association_i…

1a0af5f

…nvalid_certificate' has been removed.

ewbankkit requested review from breathingdust and justinretzolk as code owners January 29, 2025 13:13

YakDriver approved these changes Jan 29, 2025

View reviewed changes

ewbankkit merged commit b7c675d into hashicorp:main Jan 29, 2025
50 checks passed

drewtul deleted the f-vpcendpoint-resource-configuration branch January 29, 2025 15:47

github-actions bot added this to the v5.85.0 milestone Jan 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Add `resource_configuration_arn` and `service_network_arn` to `vpc_endpoint` #41116

[Enhancement] Add `resource_configuration_arn` and `service_network_arn` to `vpc_endpoint` #41116

drewtul commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025

ewbankkit left a comment

ewbankkit commented Jan 29, 2025

ewbankkit commented Jan 29, 2025

[Enhancement] Add resource_configuration_arn and service_network_arn to vpc_endpoint #41116

[Enhancement] Add resource_configuration_arn and service_network_arn to vpc_endpoint #41116

Conversation

drewtul commented Jan 28, 2025 • edited Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Jan 28, 2025

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Jan 29, 2025

ewbankkit commented Jan 29, 2025

[Enhancement] Add `resource_configuration_arn` and `service_network_arn` to `vpc_endpoint` #41116

[Enhancement] Add `resource_configuration_arn` and `service_network_arn` to `vpc_endpoint` #41116

drewtul commented Jan 28, 2025 •

edited

Loading